cc/resources/image_layer_updater.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/image_layer_updater.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/image_layer_updater.cc

diff --git a/cc/resources/image_layer_updater.cc b/cc/resources/image_layer_updater.cc

index 470f518b424dfd38065a415f14d6ecf7503e2485..e6900b7a2988e5333bcbd1cc2ba8408a368e1a33 100644

--- a/cc/resources/image_layer_updater.cc

+++ b/cc/resources/image_layer_updater.cc

@@ -15,7 +15,7 @@ ImageLayerUpdater::Resource::Resource(ImageLayerUpdater* updater,

ImageLayerUpdater::Resource::~Resource() {}

void ImageLayerUpdater::Resource::Update(ResourceUpdateQueue* queue,

- gfx::Rect source_rect,

+ const gfx::Rect& source_rect,

gfx::Vector2d dest_offset,

bool partial_update) {

updater_->UpdateTexture(

@@ -35,7 +35,7 @@ scoped_ptr<LayerUpdater::Resource> ImageLayerUpdater::CreateResource(

void ImageLayerUpdater::UpdateTexture(ResourceUpdateQueue* queue,

PrioritizedResource* texture,

- gfx::Rect source_rect,

+ const gfx::Rect& source_rect,

gfx::Vector2d dest_offset,

bool partial_update) {

// Source rect should never go outside the image pixels, even if this

« no previous file with comments | « cc/resources/image_layer_updater.h ('k') | cc/resources/layer_painter.h » ('j') | no next file with comments »