cc/resources/bitmap_skpicture_content_layer_updater.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/bitmap_skpicture_content_layer_updater.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/bitmap_skpicture_content_layer_updater.h

diff --git a/cc/resources/bitmap_skpicture_content_layer_updater.h b/cc/resources/bitmap_skpicture_content_layer_updater.h

index e03f56d853da51eb55ce2b208efccbe08c2a638c..6bdebcf6f0c00d96f4c6cfa32d872b52484aa926 100644

--- a/cc/resources/bitmap_skpicture_content_layer_updater.h

+++ b/cc/resources/bitmap_skpicture_content_layer_updater.h

@@ -21,7 +21,7 @@ class BitmapSkPictureContentLayerUpdater : public SkPictureContentLayerUpdater {

scoped_ptr<PrioritizedResource> texture);

virtual void Update(ResourceUpdateQueue* queue,

- gfx::Rect source_rect,

+ const gfx::Rect& source_rect,

gfx::Vector2d dest_offset,

bool partial_update) OVERRIDE;

@@ -40,7 +40,7 @@ class BitmapSkPictureContentLayerUpdater : public SkPictureContentLayerUpdater {

virtual scoped_ptr<LayerUpdater::Resource> CreateResource(

PrioritizedResourceManager* manager) OVERRIDE;

void PaintContentsRect(SkCanvas* canvas,

- gfx::Rect source_rect);

+ const gfx::Rect& source_rect);

private:

BitmapSkPictureContentLayerUpdater(

« no previous file with comments | « cc/resources/bitmap_content_layer_updater.cc ('k') | cc/resources/bitmap_skpicture_content_layer_updater.cc » ('j') | no next file with comments »