cc/quads/yuv_video_draw_quad.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/yuv_video_draw_quad.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/yuv_video_draw_quad.h

diff --git a/cc/quads/yuv_video_draw_quad.h b/cc/quads/yuv_video_draw_quad.h

index aa750fa8ba91a510cfcacd37726eabda3272e2f4..02d307ff6a90ed070b51f5ec1f5c0b432d919a48 100644

--- a/cc/quads/yuv_video_draw_quad.h

+++ b/cc/quads/yuv_video_draw_quad.h

@@ -20,8 +20,8 @@ class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {

static scoped_ptr<YUVVideoDrawQuad> Create();

void SetNew(const SharedQuadState* shared_quad_state,

- gfx::Rect rect,

- gfx::Rect opaque_rect,

+ const gfx::Rect& rect,

+ const gfx::Rect& opaque_rect,

gfx::SizeF tex_scale,

unsigned y_plane_resource_id,

unsigned u_plane_resource_id,

@@ -29,9 +29,9 @@ class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {

unsigned a_plane_resource_id);

void SetAll(const SharedQuadState* shared_quad_state,

- gfx::Rect rect,

- gfx::Rect opaque_rect,

- gfx::Rect visible_rect,

+ const gfx::Rect& rect,

+ const gfx::Rect& opaque_rect,

+ const gfx::Rect& visible_rect,

bool needs_blending,

gfx::SizeF tex_scale,

unsigned y_plane_resource_id,

« no previous file with comments | « cc/quads/tile_draw_quad.cc ('k') | cc/quads/yuv_video_draw_quad.cc » ('j') | no next file with comments »