Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: cc/quads/render_pass_draw_quad.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/render_pass.cc ('k') | cc/quads/render_pass_draw_quad.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/render_pass_draw_quad.h
diff --git a/cc/quads/render_pass_draw_quad.h b/cc/quads/render_pass_draw_quad.h
index 8546c45621c164737602356f3a37c2cfaf165630..28b58dbf4d15cbe066222b552a0b3b966fed020a 100644
--- a/cc/quads/render_pass_draw_quad.h
+++ b/cc/quads/render_pass_draw_quad.h
@@ -21,25 +21,25 @@ class CC_EXPORT RenderPassDrawQuad : public DrawQuad {
virtual ~RenderPassDrawQuad();
void SetNew(const SharedQuadState* shared_quad_state,
- gfx::Rect rect,
+ const gfx::Rect& rect,
RenderPass::Id render_pass_id,
bool is_replica,
ResourceProvider::ResourceId mask_resource_id,
- gfx::Rect contents_changed_since_last_frame,
- gfx::RectF mask_uv_rect,
+ const gfx::Rect& contents_changed_since_last_frame,
+ const gfx::RectF& mask_uv_rect,
const FilterOperations& filters,
const FilterOperations& background_filters);
void SetAll(const SharedQuadState* shared_quad_state,
- gfx::Rect rect,
- gfx::Rect opaque_rect,
- gfx::Rect visible_rect,
+ const gfx::Rect& rect,
+ const gfx::Rect& opaque_rect,
+ const gfx::Rect& visible_rect,
bool needs_blending,
RenderPass::Id render_pass_id,
bool is_replica,
ResourceProvider::ResourceId mask_resource_id,
- gfx::Rect contents_changed_since_last_frame,
- gfx::RectF mask_uv_rect,
+ const gfx::Rect& contents_changed_since_last_frame,
+ const gfx::RectF& mask_uv_rect,
const FilterOperations& filters,
const FilterOperations& background_filters);
« no previous file with comments | « cc/quads/render_pass.cc ('k') | cc/quads/render_pass_draw_quad.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698