cc/quads/io_surface_draw_quad.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/io_surface_draw_quad.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/io_surface_draw_quad.cc

diff --git a/cc/quads/io_surface_draw_quad.cc b/cc/quads/io_surface_draw_quad.cc

index 2c986dd3a23f41935eb5d368813504015fa68586..a415d06309fd51ceee9e0b8ef15a933f5f5ac9b5 100644

--- a/cc/quads/io_surface_draw_quad.cc

+++ b/cc/quads/io_surface_draw_quad.cc

@@ -20,8 +20,8 @@ scoped_ptr<IOSurfaceDrawQuad> IOSurfaceDrawQuad::Create() {

}

void IOSurfaceDrawQuad::SetNew(const SharedQuadState* shared_quad_state,

- gfx::Rect rect,

- gfx::Rect opaque_rect,

+ const gfx::Rect& rect,

+ const gfx::Rect& opaque_rect,

gfx::Size io_surface_size,

unsigned io_surface_resource_id,

Orientation orientation) {

@@ -35,9 +35,9 @@ void IOSurfaceDrawQuad::SetNew(const SharedQuadState* shared_quad_state,

}

void IOSurfaceDrawQuad::SetAll(const SharedQuadState* shared_quad_state,

- gfx::Rect rect,

- gfx::Rect opaque_rect,

- gfx::Rect visible_rect,

+ const gfx::Rect& rect,

+ const gfx::Rect& opaque_rect,

+ const gfx::Rect& visible_rect,

bool needs_blending,

gfx::Size io_surface_size,

unsigned io_surface_resource_id,

« no previous file with comments | « cc/quads/io_surface_draw_quad.h ('k') | cc/quads/picture_draw_quad.h » ('j') | no next file with comments »