Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3008)

Unified Diff: cc/output/software_output_device.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/renderer_pixeltest.cc ('k') | cc/output/software_output_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/software_output_device.h
diff --git a/cc/output/software_output_device.h b/cc/output/software_output_device.h
index 4ecf1fedd8e8bb4f2a0b557275453dc4bf3c8b13..e203902f2e2c8ff58a3f07ef8b2b7e7aa12b5b3e 100644
--- a/cc/output/software_output_device.h
+++ b/cc/output/software_output_device.h
@@ -42,7 +42,7 @@ class CC_EXPORT SoftwareOutputDevice {
// SkCanvas. The |SoftwareOutputDevice| implementation needs to provide a
// valid SkCanvas of at least size |damage_rect|. This class retains ownership
// of the SkCanvas.
- virtual SkCanvas* BeginPaint(gfx::Rect damage_rect);
+ virtual SkCanvas* BeginPaint(const gfx::Rect& damage_rect);
// Called on FinishDrawingFrame. The compositor will no longer mutate the the
// SkCanvas instance returned by |BeginPaint| and should discard any reference
@@ -51,12 +51,12 @@ class CC_EXPORT SoftwareOutputDevice {
// Copies pixels inside |rect| from the current software framebuffer to
// |output|. Fails if there is no current softwareframebuffer.
- virtual void CopyToBitmap(gfx::Rect rect, SkBitmap* output);
+ virtual void CopyToBitmap(const gfx::Rect& rect, SkBitmap* output);
// Blit the pixel content of the SoftwareOutputDevice by |delta| with the
// write clipped to |clip_rect|.
virtual void Scroll(gfx::Vector2d delta,
- gfx::Rect clip_rect);
+ const gfx::Rect& clip_rect);
// Discard the backing buffer in the surface provided by this instance.
virtual void DiscardBackbuffer() {}
« no previous file with comments | « cc/output/renderer_pixeltest.cc ('k') | cc/output/software_output_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698