cc/output/output_surface_client.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/output_surface_client.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/output_surface_client.h

diff --git a/cc/output/output_surface_client.h b/cc/output/output_surface_client.h

index d82f30df4992c96d0f4013ddc4f50788883a940e..7e509a8269ec9f255ece21b101699ca1407c2109 100644

--- a/cc/output/output_surface_client.h

+++ b/cc/output/output_surface_client.h

@@ -30,15 +30,15 @@ class CC_EXPORT OutputSurfaceClient {

virtual bool DeferredInitialize(

scoped_refptr<ContextProvider> offscreen_context_provider) = 0;

virtual void ReleaseGL() = 0;

- virtual void SetNeedsRedrawRect(gfx::Rect damage_rect) = 0;

+ virtual void SetNeedsRedrawRect(const gfx::Rect& damage_rect) = 0;

virtual void BeginImplFrame(const BeginFrameArgs& args) = 0;

virtual void DidSwapBuffers() = 0;

virtual void OnSwapBuffersComplete() = 0;

virtual void ReclaimResources(const CompositorFrameAck* ack) = 0;

virtual void DidLoseOutputSurface() = 0;

virtual void SetExternalDrawConstraints(const gfx::Transform& transform,

- gfx::Rect viewport,

- gfx::Rect clip,

+ const gfx::Rect& viewport,

+ const gfx::Rect& clip,

bool valid_for_tile_management) = 0;

virtual void SetMemoryPolicy(const ManagedMemoryPolicy& policy) = 0;

// If set, |callback| will be called subsequent to each new tree activation,

« no previous file with comments | « cc/output/output_surface.cc ('k') | cc/output/renderer.h » ('j') | no next file with comments »