cc/layers/ui_resource_layer_impl_unittest.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/ui_resource_layer_impl_unittest.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/ui_resource_layer_impl_unittest.cc

diff --git a/cc/layers/ui_resource_layer_impl_unittest.cc b/cc/layers/ui_resource_layer_impl_unittest.cc

index 4a2a1164182a602e385c82bde2cd7a4e6f236364..4c55f1d4c4c4b8eb37d7c0fbb5c1f0d2e3e72119 100644

--- a/cc/layers/ui_resource_layer_impl_unittest.cc

+++ b/cc/layers/ui_resource_layer_impl_unittest.cc

@@ -89,7 +89,7 @@ TEST(UIResourceLayerImplTest, VerifyDrawQuads) {

}

void OpaqueBoundsTest(scoped_ptr<UIResourceLayerImpl> layer,

- gfx::Rect expected_opaque_bounds) {

+ const gfx::Rect& expected_opaque_bounds) {

MockQuadCuller quad_culler;

AppendQuadsData data;

layer->AppendQuads(&quad_culler, &data);

« no previous file with comments | « cc/layers/tiled_layer_unittest.cc ('k') | cc/output/copy_output_request.h » ('j') | no next file with comments »