cc/layers/tiled_layer.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/tiled_layer.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/tiled_layer.h

diff --git a/cc/layers/tiled_layer.h b/cc/layers/tiled_layer.h

index 82063600c71deabeb892babb17928329651c38c7..f2f7e96293f38632823ca6245ec8b09f59249ccc 100644

--- a/cc/layers/tiled_layer.h

+++ b/cc/layers/tiled_layer.h

@@ -57,7 +57,7 @@ class CC_EXPORT TiledLayer : public ContentsScalingLayer {

virtual void CreateUpdaterIfNeeded() = 0;

// Set invalidations to be potentially repainted during Update().

- void InvalidateContentRect(gfx::Rect content_rect);

+ void InvalidateContentRect(const gfx::Rect& content_rect);

// Reset state on tiles that will be used for updating the layer.

void ResetUpdateState();

@@ -110,8 +110,8 @@ class CC_EXPORT TiledLayer : public ContentsScalingLayer {

int right,

int bottom,

bool ignore_occlusions);

- void UpdateTileTextures(gfx::Rect update_rect,

- gfx::Rect paint_rect,

+ void UpdateTileTextures(const gfx::Rect& update_rect,

+ const gfx::Rect& paint_rect,

int left,

int top,

int right,

« no previous file with comments | « cc/layers/scrollbar_theme_painter.h ('k') | cc/layers/tiled_layer.cc » ('j') | no next file with comments »