cc/layers/picture_layer_impl.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl.h

diff --git a/cc/layers/picture_layer_impl.h b/cc/layers/picture_layer_impl.h

index f9ac16d69426efe765ef6b2e85b225d8a3d064fb..4b9e3ac52a6460bcce40eea17945e19e1c48837d 100644

--- a/cc/layers/picture_layer_impl.h

+++ b/cc/layers/picture_layer_impl.h

@@ -53,8 +53,9 @@ class CC_EXPORT PictureLayerImpl

virtual skia::RefPtr<SkPicture> GetPicture() OVERRIDE;

// PictureLayerTilingClient overrides.

- virtual scoped_refptr<Tile> CreateTile(PictureLayerTiling* tiling,

- gfx::Rect content_rect) OVERRIDE;

+ virtual scoped_refptr<Tile> CreateTile(

+ PictureLayerTiling* tiling,

+ const gfx::Rect& content_rect) OVERRIDE;

virtual void UpdatePile(Tile* tile) OVERRIDE;

virtual gfx::Size CalculateTileSize(

gfx::Size content_bounds) const OVERRIDE;

@@ -100,7 +101,7 @@ class CC_EXPORT PictureLayerImpl

PictureLayerTiling* tiling,

const PictureLayerTiling* optional_twin_tiling,

float contents_scale,

- gfx::Rect rect,

+ const gfx::Rect& rect,

const Region& missing_region) const;

void DoPostCommitInitializationIfNeeded() {

« no previous file with comments | « cc/layers/picture_image_layer.cc ('k') | cc/layers/picture_layer_impl.cc » ('j') | no next file with comments »