cc/layers/painted_scrollbar_layer.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/painted_scrollbar_layer.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/painted_scrollbar_layer.h

diff --git a/cc/layers/painted_scrollbar_layer.h b/cc/layers/painted_scrollbar_layer.h

index 606ad69b9056f8a88e223dbe8effc19955053d53..c24c0aa70e329fd3892ac466ee3771f424a0b5b1 100644

--- a/cc/layers/painted_scrollbar_layer.h

+++ b/cc/layers/painted_scrollbar_layer.h

@@ -62,7 +62,7 @@ class CC_EXPORT PaintedScrollbarLayer : public ScrollbarLayerInterface,

void UpdateThumbAndTrackGeometry();

private:

- gfx::Rect ScrollbarLayerRectToContentRect(gfx::Rect layer_rect) const;

+ gfx::Rect ScrollbarLayerRectToContentRect(const gfx::Rect& layer_rect) const;

gfx::Rect OriginThumbRect() const;

template<typename T> void UpdateProperty(T value, T* prop) {

@@ -75,7 +75,7 @@ class CC_EXPORT PaintedScrollbarLayer : public ScrollbarLayerInterface,

int MaxTextureSize();

float ClampScaleToMaxTextureSize(float scale);

- UIResourceBitmap RasterizeScrollbarPart(gfx::Rect rect,

+ UIResourceBitmap RasterizeScrollbarPart(const gfx::Rect& rect,

ScrollbarPart part);

scoped_ptr<Scrollbar> scrollbar_;

« no previous file with comments | « cc/layers/nine_patch_layer_impl_unittest.cc ('k') | cc/layers/painted_scrollbar_layer.cc » ('j') | no next file with comments »