cc/layers/delegated_renderer_layer_impl.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/delegated_renderer_layer_impl.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/delegated_renderer_layer_impl.cc

diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc

index b2019c3d9e9d5f4b4e9633108adcf1da65d1ee11..4b9d90fadd741d5883941eb4eea97a0b1de46884 100644

--- a/cc/layers/delegated_renderer_layer_impl.cc

+++ b/cc/layers/delegated_renderer_layer_impl.cc

@@ -100,7 +100,7 @@ void DelegatedRendererLayerImpl::CreateChildIdIfNeeded(

void DelegatedRendererLayerImpl::SetFrameData(

const DelegatedFrameData* frame_data,

- gfx::RectF damage_in_frame) {

+ const gfx::RectF& damage_in_frame) {

DCHECK(child_id_) << "CreateChildIdIfNeeded must be called first.";

DCHECK(frame_data);

DCHECK(!frame_data->render_pass_list.empty());

« no previous file with comments | « cc/layers/delegated_renderer_layer_impl.h ('k') | cc/layers/layer_perftest.cc » ('j') | no next file with comments »