cc/layers/delegated_frame_provider_unittest.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/delegated_frame_provider_unittest.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/delegated_frame_provider_unittest.cc

diff --git a/cc/layers/delegated_frame_provider_unittest.cc b/cc/layers/delegated_frame_provider_unittest.cc

index 20b355c6192bcbb0bd071343dbbc13b1f061edc9..2a4f564818e04f6bc4665b3a5c563fe3cecf0ae1 100644

--- a/cc/layers/delegated_frame_provider_unittest.cc

+++ b/cc/layers/delegated_frame_provider_unittest.cc

@@ -20,8 +20,9 @@ class DelegatedFrameProviderTest

protected:

DelegatedFrameProviderTest() : resources_available_(false) {}

- scoped_ptr<DelegatedFrameData> CreateFrameData(gfx::Rect root_output_rect,

- gfx::Rect root_damage_rect) {

+ scoped_ptr<DelegatedFrameData> CreateFrameData(

+ const gfx::Rect& root_output_rect,

+ const gfx::Rect& root_damage_rect) {

scoped_ptr<DelegatedFrameData> frame(new DelegatedFrameData);

scoped_ptr<RenderPass> root_pass(RenderPass::Create());

« no previous file with comments | « cc/layers/content_layer_unittest.cc ('k') | cc/layers/delegated_renderer_layer_impl.h » ('j') | no next file with comments »