cc/base/tiling_data.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/tiling_data.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/base/tiling_data.h

diff --git a/cc/base/tiling_data.h b/cc/base/tiling_data.h

index 3bf9809579fb9738580ebc8ddc64c2603b65fc89..96e6ae080384bb1472f2ecc56d09ef6348b76f07 100644

--- a/cc/base/tiling_data.h

+++ b/cc/base/tiling_data.h

@@ -89,7 +89,7 @@ class CC_EXPORT TilingData {

// Iterate through all indices whose bounds + border intersect with |rect|.

class CC_EXPORT Iterator : public BaseIterator {

public:

- Iterator(const TilingData* tiling_data, gfx::Rect rect);

+ Iterator(const TilingData* tiling_data, const gfx::Rect& tiling_rect);

Iterator& operator++();

private:

@@ -104,8 +104,8 @@ class CC_EXPORT TilingData {

public:

DifferenceIterator(

const TilingData* tiling_data,

- gfx::Rect consider,

- gfx::Rect ignore);

+ const gfx::Rect& consider_rect,

+ const gfx::Rect& ignore_rect);

DifferenceIterator& operator++();

private:

« no previous file with comments | « cc/base/region.cc ('k') | cc/base/tiling_data.cc » ('j') | no next file with comments »