cc/base/math_util.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/math_util.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/base/math_util.h

diff --git a/cc/base/math_util.h b/cc/base/math_util.h

index baceb7058fe3a51b028a8bbe8f3b80daf3f94e9a..fd6f033da2f08ff4d677e76a7d2e1e734f03e5e7 100644

--- a/cc/base/math_util.h

+++ b/cc/base/math_util.h

@@ -100,7 +100,7 @@ class CC_EXPORT MathUtil {

// These functions return the axis-aligned rect that encloses the correctly

// clipped, transformed polygon.

static gfx::Rect MapClippedRect(const gfx::Transform& transform,

- gfx::Rect rect);

+ const gfx::Rect& rect);

static gfx::RectF MapClippedRect(const gfx::Transform& transform,

const gfx::RectF& rect);

static gfx::RectF ProjectClippedRect(const gfx::Transform& transform,

@@ -167,7 +167,7 @@ class CC_EXPORT MathUtil {

// Conversion to value.

static scoped_ptr<base::Value> AsValue(gfx::Size s);

static scoped_ptr<base::Value> AsValue(gfx::SizeF s);

- static scoped_ptr<base::Value> AsValue(gfx::Rect r);

+ static scoped_ptr<base::Value> AsValue(const gfx::Rect& r);

static bool FromValue(const base::Value*, gfx::Rect* out_rect);

static scoped_ptr<base::Value> AsValue(gfx::PointF q);

static scoped_ptr<base::Value> AsValue(const gfx::QuadF& q);

« no previous file with comments | « cc/base/invalidation_region.cc ('k') | cc/base/math_util.cc » ('j') | no next file with comments »