cc/test/skia_common.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/test/skia_common.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/test/render_pass_test_utils.cc ('k') | cc/test/skia_common.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_TEST_SKIA_COMMON_H_	5 #ifndef CC_TEST_SKIA_COMMON_H_

6 #define CC_TEST_SKIA_COMMON_H_	6 #define CC_TEST_SKIA_COMMON_H_

7	7

8 #include "base/memory/ref_counted.h"	8 #include "base/memory/ref_counted.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10 #include "third_party/skia/include/core/SkBitmap.h"	10 #include "third_party/skia/include/core/SkBitmap.h"

(...skipping 17 matching lines...) Expand all Loading...
28 virtual void* onLockPixels(SkColorTable** color_table) OVERRIDE;	28 virtual void* onLockPixels(SkColorTable** color_table) OVERRIDE;

29 virtual void onUnlockPixels() OVERRIDE {}	29 virtual void onUnlockPixels() OVERRIDE {}

30 virtual SkPixelRef* deepCopy(	30 virtual SkPixelRef* deepCopy(

31 SkBitmap::Config config,	31 SkBitmap::Config config,

32 const SkIRect* subset) OVERRIDE;	32 const SkIRect* subset) OVERRIDE;

33 private:	33 private:

34 scoped_ptr<char[]> pixels_;	34 scoped_ptr<char[]> pixels_;

35 };	35 };

36	36

37 void DrawPicture(unsigned char* buffer,	37 void DrawPicture(unsigned char* buffer,

38 gfx::Rect layer_rect,	38 const gfx::Rect& layer_rect,

39 scoped_refptr<Picture> picture);	39 scoped_refptr<Picture> picture);

40	40

41 void CreateBitmap(gfx::Size size, const char* uri, SkBitmap* bitmap);	41 void CreateBitmap(gfx::Size size, const char* uri, SkBitmap* bitmap);

42	42

43 } // namespace cc	43 } // namespace cc

44	44

45 #endif // CC_TEST_SKIA_COMMON_H_	45 #endif // CC_TEST_SKIA_COMMON_H_

OLD	NEW