[#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

cc/scheduler/texture_uploader.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler/texture_uploader.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/debug/trace_event.h"
@@ skipping 111 matching lines @@
   available_queries_.front()->Begin();
 }
 
 void TextureUploader::EndQuery() {
   available_queries_.front()->End();
   pending_queries_.push_back(available_queries_.take_front());
   num_blocking_texture_uploads_++;
 }
 
 void TextureUploader::Upload(const uint8* image,
-                             gfx::Rect image_rect,
-                             gfx::Rect source_rect,
+                             const gfx::Rect& image_rect,
+                             const gfx::Rect& source_rect,
                              gfx::Vector2d dest_offset,
                              ResourceFormat format,
                              gfx::Size size) {
   CHECK(image_rect.Contains(source_rect));
 
   bool is_full_upload = dest_offset.IsZero() && source_rect.size() == size;
 
   if (is_full_upload)
     BeginQuery();
 
@@ skipping 22 matching lines @@
 
   num_texture_uploads_since_last_flush_ = 0;
 }
 
 void TextureUploader::ReleaseCachedQueries() {
   ProcessQueries();
   available_queries_.clear();
 }
 
 void TextureUploader::UploadWithTexSubImage(const uint8* image,
-                                            gfx::Rect image_rect,
-                                            gfx::Rect source_rect,
+                                            const gfx::Rect& image_rect,
+                                            const gfx::Rect& source_rect,
                                             gfx::Vector2d dest_offset,
                                             ResourceFormat format) {
   TRACE_EVENT0("cc", "TextureUploader::UploadWithTexSubImage");
 
   // Early-out if this is a no-op, and assert that |image| be valid if this is
   // not a no-op.
   if (source_rect.IsEmpty())
     return;
   DCHECK(image);
 
@@ skipping 32 matching lines @@
                      dest_offset.x(),
                      dest_offset.y(),
                      source_rect.width(),
                      source_rect.height(),
                      GLDataFormat(format),
                      GLDataType(format),
                      pixel_source);
 }
 
 void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
-                                               gfx::Rect image_rect,
-                                               gfx::Rect source_rect,
+                                               const gfx::Rect& image_rect,
+                                               const gfx::Rect& source_rect,
                                                gfx::Vector2d dest_offset,
                                                ResourceFormat format) {
   TRACE_EVENT0("cc", "TextureUploader::UploadWithMapTexSubImage");
 
   // Early-out if this is a no-op, and assert that |image| be valid if this is
   // not a no-op.
   if (source_rect.IsEmpty())
     return;
   DCHECK(image);
   // Compressed textures have no implementation of mapTexSubImage.
@@ skipping 82 matching lines @@
       textures_per_second_history_.erase(textures_per_second_history_.begin());
       textures_per_second_history_.erase(--textures_per_second_history_.end());
     }
     textures_per_second_history_.insert(textures_per_second);
 
     available_queries_.push_back(pending_queries_.take_front());
   }
 }
 
 }  // namespace cc