Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Side by Side Diff: cc/quads/solid_color_draw_quad.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/solid_color_draw_quad.h ('k') | cc/quads/stream_video_draw_quad.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/solid_color_draw_quad.h" 5 #include "cc/quads/solid_color_draw_quad.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 namespace cc { 10 namespace cc {
11 11
12 SolidColorDrawQuad::SolidColorDrawQuad() 12 SolidColorDrawQuad::SolidColorDrawQuad()
13 : color(0), force_anti_aliasing_off(false) {} 13 : color(0), force_anti_aliasing_off(false) {}
14 14
15 scoped_ptr<SolidColorDrawQuad> SolidColorDrawQuad::Create() { 15 scoped_ptr<SolidColorDrawQuad> SolidColorDrawQuad::Create() {
16 return make_scoped_ptr(new SolidColorDrawQuad); 16 return make_scoped_ptr(new SolidColorDrawQuad);
17 } 17 }
18 18
19 void SolidColorDrawQuad::SetNew(const SharedQuadState* shared_quad_state, 19 void SolidColorDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
20 gfx::Rect rect, 20 const gfx::Rect& rect,
21 SkColor color, 21 SkColor color,
22 bool force_anti_aliasing_off) { 22 bool force_anti_aliasing_off) {
23 gfx::Rect opaque_rect = SkColorGetA(color) == 255 ? rect : gfx::Rect(); 23 gfx::Rect opaque_rect = SkColorGetA(color) == 255 ? rect : gfx::Rect();
24 gfx::Rect visible_rect = rect; 24 gfx::Rect visible_rect = rect;
25 bool needs_blending = false; 25 bool needs_blending = false;
26 DrawQuad::SetAll(shared_quad_state, DrawQuad::SOLID_COLOR, rect, opaque_rect, 26 DrawQuad::SetAll(shared_quad_state, DrawQuad::SOLID_COLOR, rect, opaque_rect,
27 visible_rect, needs_blending); 27 visible_rect, needs_blending);
28 this->color = color; 28 this->color = color;
29 this->force_anti_aliasing_off = force_anti_aliasing_off; 29 this->force_anti_aliasing_off = force_anti_aliasing_off;
30 } 30 }
31 31
32 void SolidColorDrawQuad::SetAll(const SharedQuadState* shared_quad_state, 32 void SolidColorDrawQuad::SetAll(const SharedQuadState* shared_quad_state,
33 gfx::Rect rect, 33 const gfx::Rect& rect,
34 gfx::Rect opaque_rect, 34 const gfx::Rect& opaque_rect,
35 gfx::Rect visible_rect, 35 const gfx::Rect& visible_rect,
36 bool needs_blending, 36 bool needs_blending,
37 SkColor color, 37 SkColor color,
38 bool force_anti_aliasing_off) { 38 bool force_anti_aliasing_off) {
39 DrawQuad::SetAll(shared_quad_state, DrawQuad::SOLID_COLOR, rect, opaque_rect, 39 DrawQuad::SetAll(shared_quad_state, DrawQuad::SOLID_COLOR, rect, opaque_rect,
40 visible_rect, needs_blending); 40 visible_rect, needs_blending);
41 this->color = color; 41 this->color = color;
42 this->force_anti_aliasing_off = force_anti_aliasing_off; 42 this->force_anti_aliasing_off = force_anti_aliasing_off;
43 } 43 }
44 44
45 void SolidColorDrawQuad::IterateResources( 45 void SolidColorDrawQuad::IterateResources(
46 const ResourceIteratorCallback& callback) {} 46 const ResourceIteratorCallback& callback) {}
47 47
48 const SolidColorDrawQuad* SolidColorDrawQuad::MaterialCast( 48 const SolidColorDrawQuad* SolidColorDrawQuad::MaterialCast(
49 const DrawQuad* quad) { 49 const DrawQuad* quad) {
50 DCHECK(quad->material == DrawQuad::SOLID_COLOR); 50 DCHECK(quad->material == DrawQuad::SOLID_COLOR);
51 return static_cast<const SolidColorDrawQuad*>(quad); 51 return static_cast<const SolidColorDrawQuad*>(quad);
52 } 52 }
53 53
54 void SolidColorDrawQuad::ExtendValue(base::DictionaryValue* value) const { 54 void SolidColorDrawQuad::ExtendValue(base::DictionaryValue* value) const {
55 value->SetInteger("color", color); 55 value->SetInteger("color", color);
56 value->SetBoolean("force_anti_aliasing_off", force_anti_aliasing_off); 56 value->SetBoolean("force_anti_aliasing_off", force_anti_aliasing_off);
57 } 57 }
58 58
59 } // namespace cc 59 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/solid_color_draw_quad.h ('k') | cc/quads/stream_video_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698