Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: cc/quads/render_pass_draw_quad.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/render_pass_draw_quad.h ('k') | cc/quads/shared_quad_state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/render_pass_draw_quad.h" 5 #include "cc/quads/render_pass_draw_quad.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "cc/base/math_util.h" 8 #include "cc/base/math_util.h"
9 #include "cc/debug/traced_value.h" 9 #include "cc/debug/traced_value.h"
10 #include "third_party/skia/include/core/SkImageFilter.h" 10 #include "third_party/skia/include/core/SkImageFilter.h"
(...skipping 18 matching lines...) Expand all
29 RenderPass::Id copied_render_pass_id) const { 29 RenderPass::Id copied_render_pass_id) const {
30 scoped_ptr<RenderPassDrawQuad> copy_quad( 30 scoped_ptr<RenderPassDrawQuad> copy_quad(
31 new RenderPassDrawQuad(*MaterialCast(this))); 31 new RenderPassDrawQuad(*MaterialCast(this)));
32 copy_quad->shared_quad_state = copied_shared_quad_state; 32 copy_quad->shared_quad_state = copied_shared_quad_state;
33 copy_quad->render_pass_id = copied_render_pass_id; 33 copy_quad->render_pass_id = copied_render_pass_id;
34 return copy_quad.Pass(); 34 return copy_quad.Pass();
35 } 35 }
36 36
37 void RenderPassDrawQuad::SetNew( 37 void RenderPassDrawQuad::SetNew(
38 const SharedQuadState* shared_quad_state, 38 const SharedQuadState* shared_quad_state,
39 gfx::Rect rect, 39 const gfx::Rect& rect,
40 RenderPass::Id render_pass_id, 40 RenderPass::Id render_pass_id,
41 bool is_replica, 41 bool is_replica,
42 ResourceProvider::ResourceId mask_resource_id, 42 ResourceProvider::ResourceId mask_resource_id,
43 gfx::Rect contents_changed_since_last_frame, 43 const gfx::Rect& contents_changed_since_last_frame,
44 gfx::RectF mask_uv_rect, 44 const gfx::RectF& mask_uv_rect,
45 const FilterOperations& filters, 45 const FilterOperations& filters,
46 const FilterOperations& background_filters) { 46 const FilterOperations& background_filters) {
47 DCHECK_GT(render_pass_id.layer_id, 0); 47 DCHECK_GT(render_pass_id.layer_id, 0);
48 DCHECK_GE(render_pass_id.index, 0); 48 DCHECK_GE(render_pass_id.index, 0);
49 49
50 gfx::Rect opaque_rect; 50 gfx::Rect opaque_rect;
51 gfx::Rect visible_rect = rect; 51 gfx::Rect visible_rect = rect;
52 bool needs_blending = false; 52 bool needs_blending = false;
53 SetAll(shared_quad_state, rect, opaque_rect, visible_rect, needs_blending, 53 SetAll(shared_quad_state, rect, opaque_rect, visible_rect, needs_blending,
54 render_pass_id, is_replica, mask_resource_id, 54 render_pass_id, is_replica, mask_resource_id,
55 contents_changed_since_last_frame, mask_uv_rect, filters, 55 contents_changed_since_last_frame, mask_uv_rect, filters,
56 background_filters); 56 background_filters);
57 } 57 }
58 58
59 void RenderPassDrawQuad::SetAll( 59 void RenderPassDrawQuad::SetAll(
60 const SharedQuadState* shared_quad_state, 60 const SharedQuadState* shared_quad_state,
61 gfx::Rect rect, 61 const gfx::Rect& rect,
62 gfx::Rect opaque_rect, 62 const gfx::Rect& opaque_rect,
63 gfx::Rect visible_rect, 63 const gfx::Rect& visible_rect,
64 bool needs_blending, 64 bool needs_blending,
65 RenderPass::Id render_pass_id, 65 RenderPass::Id render_pass_id,
66 bool is_replica, 66 bool is_replica,
67 ResourceProvider::ResourceId mask_resource_id, 67 ResourceProvider::ResourceId mask_resource_id,
68 gfx::Rect contents_changed_since_last_frame, 68 const gfx::Rect& contents_changed_since_last_frame,
69 gfx::RectF mask_uv_rect, 69 const gfx::RectF& mask_uv_rect,
70 const FilterOperations& filters, 70 const FilterOperations& filters,
71 const FilterOperations& background_filters) { 71 const FilterOperations& background_filters) {
72 DCHECK_GT(render_pass_id.layer_id, 0); 72 DCHECK_GT(render_pass_id.layer_id, 0);
73 DCHECK_GE(render_pass_id.index, 0); 73 DCHECK_GE(render_pass_id.index, 0);
74 74
75 DrawQuad::SetAll(shared_quad_state, DrawQuad::RENDER_PASS, rect, opaque_rect, 75 DrawQuad::SetAll(shared_quad_state, DrawQuad::RENDER_PASS, rect, opaque_rect,
76 visible_rect, needs_blending); 76 visible_rect, needs_blending);
77 this->render_pass_id = render_pass_id; 77 this->render_pass_id = render_pass_id;
78 this->is_replica = is_replica; 78 this->is_replica = is_replica;
79 this->mask_resource_id = mask_resource_id; 79 this->mask_resource_id = mask_resource_id;
(...skipping 21 matching lines...) Expand all
101 value->SetBoolean("is_replica", is_replica); 101 value->SetBoolean("is_replica", is_replica);
102 value->SetInteger("mask_resource_id", mask_resource_id); 102 value->SetInteger("mask_resource_id", mask_resource_id);
103 value->Set("contents_changed_since_last_frame", 103 value->Set("contents_changed_since_last_frame",
104 MathUtil::AsValue(contents_changed_since_last_frame).release()); 104 MathUtil::AsValue(contents_changed_since_last_frame).release());
105 value->Set("mask_uv_rect", MathUtil::AsValue(mask_uv_rect).release()); 105 value->Set("mask_uv_rect", MathUtil::AsValue(mask_uv_rect).release());
106 value->Set("filters", filters.AsValue().release()); 106 value->Set("filters", filters.AsValue().release());
107 value->Set("background_filters", background_filters.AsValue().release()); 107 value->Set("background_filters", background_filters.AsValue().release());
108 } 108 }
109 109
110 } // namespace cc 110 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/render_pass_draw_quad.h ('k') | cc/quads/shared_quad_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698