Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: cc/quads/debug_border_draw_quad.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/debug_border_draw_quad.h ('k') | cc/quads/draw_quad.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/debug_border_draw_quad.h" 5 #include "cc/quads/debug_border_draw_quad.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 namespace cc { 10 namespace cc {
11 11
12 DebugBorderDrawQuad::DebugBorderDrawQuad() 12 DebugBorderDrawQuad::DebugBorderDrawQuad()
13 : color(0), 13 : color(0),
14 width(0) { 14 width(0) {
15 } 15 }
16 16
17 scoped_ptr<DebugBorderDrawQuad> DebugBorderDrawQuad::Create() { 17 scoped_ptr<DebugBorderDrawQuad> DebugBorderDrawQuad::Create() {
18 return make_scoped_ptr(new DebugBorderDrawQuad); 18 return make_scoped_ptr(new DebugBorderDrawQuad);
19 } 19 }
20 20
21 void DebugBorderDrawQuad::SetNew(const SharedQuadState* shared_quad_state, 21 void DebugBorderDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
22 gfx::Rect rect, 22 const gfx::Rect& rect,
23 SkColor color, 23 SkColor color,
24 int width) { 24 int width) {
25 gfx::Rect opaque_rect; 25 gfx::Rect opaque_rect;
26 gfx::Rect visible_rect = rect; 26 gfx::Rect visible_rect = rect;
27 bool needs_blending = SkColorGetA(color) < 255; 27 bool needs_blending = SkColorGetA(color) < 255;
28 DrawQuad::SetAll(shared_quad_state, DrawQuad::DEBUG_BORDER, rect, opaque_rect, 28 DrawQuad::SetAll(shared_quad_state, DrawQuad::DEBUG_BORDER, rect, opaque_rect,
29 visible_rect, needs_blending); 29 visible_rect, needs_blending);
30 this->color = color; 30 this->color = color;
31 this->width = width; 31 this->width = width;
32 } 32 }
33 33
34 void DebugBorderDrawQuad::SetAll(const SharedQuadState* shared_quad_state, 34 void DebugBorderDrawQuad::SetAll(const SharedQuadState* shared_quad_state,
35 gfx::Rect rect, 35 const gfx::Rect& rect,
36 gfx::Rect opaque_rect, 36 const gfx::Rect& opaque_rect,
37 gfx::Rect visible_rect, 37 const gfx::Rect& visible_rect,
38 bool needs_blending, 38 bool needs_blending,
39 SkColor color, 39 SkColor color,
40 int width) { 40 int width) {
41 DrawQuad::SetAll(shared_quad_state, DrawQuad::DEBUG_BORDER, rect, opaque_rect, 41 DrawQuad::SetAll(shared_quad_state, DrawQuad::DEBUG_BORDER, rect, opaque_rect,
42 visible_rect, needs_blending); 42 visible_rect, needs_blending);
43 this->color = color; 43 this->color = color;
44 this->width = width; 44 this->width = width;
45 } 45 }
46 46
47 void DebugBorderDrawQuad::IterateResources( 47 void DebugBorderDrawQuad::IterateResources(
48 const ResourceIteratorCallback& callback) {} 48 const ResourceIteratorCallback& callback) {}
49 49
50 const DebugBorderDrawQuad* DebugBorderDrawQuad::MaterialCast( 50 const DebugBorderDrawQuad* DebugBorderDrawQuad::MaterialCast(
51 const DrawQuad* quad) { 51 const DrawQuad* quad) {
52 DCHECK(quad->material == DrawQuad::DEBUG_BORDER); 52 DCHECK(quad->material == DrawQuad::DEBUG_BORDER);
53 return static_cast<const DebugBorderDrawQuad*>(quad); 53 return static_cast<const DebugBorderDrawQuad*>(quad);
54 } 54 }
55 55
56 void DebugBorderDrawQuad::ExtendValue(base::DictionaryValue* value) const { 56 void DebugBorderDrawQuad::ExtendValue(base::DictionaryValue* value) const {
57 value->SetInteger("color", color); 57 value->SetInteger("color", color);
58 value->SetInteger("width", width); 58 value->SetInteger("width", width);
59 } 59 }
60 60
61 } // namespace cc 61 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/debug_border_draw_quad.h ('k') | cc/quads/draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698