Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: cc/output/software_output_device.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/software_output_device.h ('k') | cc/output/software_renderer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/software_output_device.h" 5 #include "cc/output/software_output_device.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "cc/output/software_frame_data.h" 8 #include "cc/output/software_frame_data.h"
9 #include "third_party/skia/include/core/SkBitmapDevice.h" 9 #include "third_party/skia/include/core/SkBitmapDevice.h"
10 #include "third_party/skia/include/core/SkCanvas.h" 10 #include "third_party/skia/include/core/SkCanvas.h"
11 #include "ui/gfx/skia_util.h" 11 #include "ui/gfx/skia_util.h"
12 #include "ui/gfx/vsync_provider.h" 12 #include "ui/gfx/vsync_provider.h"
13 13
14 namespace cc { 14 namespace cc {
15 15
16 SoftwareOutputDevice::SoftwareOutputDevice() {} 16 SoftwareOutputDevice::SoftwareOutputDevice() {}
17 17
18 SoftwareOutputDevice::~SoftwareOutputDevice() {} 18 SoftwareOutputDevice::~SoftwareOutputDevice() {}
19 19
20 void SoftwareOutputDevice::Resize(gfx::Size viewport_size) { 20 void SoftwareOutputDevice::Resize(gfx::Size viewport_size) {
21 if (viewport_size_ == viewport_size) 21 if (viewport_size_ == viewport_size)
22 return; 22 return;
23 23
24 viewport_size_ = viewport_size; 24 viewport_size_ = viewport_size;
25 device_ = skia::AdoptRef(new SkBitmapDevice(SkBitmap::kARGB_8888_Config, 25 device_ = skia::AdoptRef(new SkBitmapDevice(SkBitmap::kARGB_8888_Config,
26 viewport_size.width(), viewport_size.height(), true)); 26 viewport_size.width(), viewport_size.height(), true));
27 canvas_ = skia::AdoptRef(new SkCanvas(device_.get())); 27 canvas_ = skia::AdoptRef(new SkCanvas(device_.get()));
28 } 28 }
29 29
30 SkCanvas* SoftwareOutputDevice::BeginPaint(gfx::Rect damage_rect) { 30 SkCanvas* SoftwareOutputDevice::BeginPaint(const gfx::Rect& damage_rect) {
31 DCHECK(device_); 31 DCHECK(device_);
32 damage_rect_ = damage_rect; 32 damage_rect_ = damage_rect;
33 return canvas_.get(); 33 return canvas_.get();
34 } 34 }
35 35
36 void SoftwareOutputDevice::EndPaint(SoftwareFrameData* frame_data) { 36 void SoftwareOutputDevice::EndPaint(SoftwareFrameData* frame_data) {
37 DCHECK(frame_data); 37 DCHECK(frame_data);
38 frame_data->id = 0; 38 frame_data->id = 0;
39 frame_data->size = viewport_size_; 39 frame_data->size = viewport_size_;
40 frame_data->damage_rect = damage_rect_; 40 frame_data->damage_rect = damage_rect_;
41 frame_data->handle = base::SharedMemory::NULLHandle(); 41 frame_data->handle = base::SharedMemory::NULLHandle();
42 } 42 }
43 43
44 void SoftwareOutputDevice::CopyToBitmap( 44 void SoftwareOutputDevice::CopyToBitmap(
45 gfx::Rect rect, SkBitmap* output) { 45 const gfx::Rect& rect, SkBitmap* output) {
46 DCHECK(device_); 46 DCHECK(device_);
47 const SkBitmap& bitmap = device_->accessBitmap(false); 47 const SkBitmap& bitmap = device_->accessBitmap(false);
48 bitmap.extractSubset(output, gfx::RectToSkIRect(rect)); 48 bitmap.extractSubset(output, gfx::RectToSkIRect(rect));
49 } 49 }
50 50
51 void SoftwareOutputDevice::Scroll( 51 void SoftwareOutputDevice::Scroll(
52 gfx::Vector2d delta, gfx::Rect clip_rect) { 52 gfx::Vector2d delta, const gfx::Rect& clip_rect) {
53 NOTIMPLEMENTED(); 53 NOTIMPLEMENTED();
54 } 54 }
55 55
56 void SoftwareOutputDevice::ReclaimSoftwareFrame(unsigned id) { 56 void SoftwareOutputDevice::ReclaimSoftwareFrame(unsigned id) {
57 NOTIMPLEMENTED(); 57 NOTIMPLEMENTED();
58 } 58 }
59 59
60 gfx::VSyncProvider* SoftwareOutputDevice::GetVSyncProvider() { 60 gfx::VSyncProvider* SoftwareOutputDevice::GetVSyncProvider() {
61 return vsync_provider_.get(); 61 return vsync_provider_.get();
62 } 62 }
63 63
64 } // namespace cc 64 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/software_output_device.h ('k') | cc/output/software_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698