cc/input/scrollbar.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/input/scrollbar.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/debug/overdraw_metrics.cc ('k') | cc/layers/content_layer.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_INPUT_SCROLLBAR_H_	5 #ifndef CC_INPUT_SCROLLBAR_H_

6 #define CC_INPUT_SCROLLBAR_H_	6 #define CC_INPUT_SCROLLBAR_H_

7	7

8 #include "cc/base/cc_export.h"	8 #include "cc/base/cc_export.h"

9 #include "ui/gfx/point.h"	9 #include "ui/gfx/point.h"

10 #include "ui/gfx/rect.h"	10 #include "ui/gfx/rect.h"

(...skipping 15 matching lines...) Expand all Loading...
26 virtual ScrollbarOrientation Orientation() const = 0;	26 virtual ScrollbarOrientation Orientation() const = 0;

27 virtual bool IsLeftSideVerticalScrollbar() const = 0;	27 virtual bool IsLeftSideVerticalScrollbar() const = 0;

28 virtual gfx::Point Location() const = 0;	28 virtual gfx::Point Location() const = 0;

29 virtual bool IsOverlay() const = 0;	29 virtual bool IsOverlay() const = 0;

30 virtual bool HasThumb() const = 0;	30 virtual bool HasThumb() const = 0;

31 virtual int ThumbThickness() const = 0;	31 virtual int ThumbThickness() const = 0;

32 virtual int ThumbLength() const = 0;	32 virtual int ThumbLength() const = 0;

33 virtual gfx::Rect TrackRect() const = 0;	33 virtual gfx::Rect TrackRect() const = 0;

34 virtual void PaintPart(SkCanvas* canvas,	34 virtual void PaintPart(SkCanvas* canvas,

35 ScrollbarPart part,	35 ScrollbarPart part,

36 gfx::Rect content_rect) = 0;	36 const gfx::Rect& content_rect) = 0;

37 };	37 };

38	38

39 } // namespace cc	39 } // namespace cc

40	40

41 #endif // CC_INPUT_SCROLLBAR_H_	41 #endif // CC_INPUT_SCROLLBAR_H_

OLD	NEW