[#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

cc/base/tiling_data.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/base/tiling_data.h"
 
 #include <algorithm>
 
 #include "ui/gfx/rect.h"
 #include "ui/gfx/vector2d.h"
@@ skipping 254 matching lines @@
   num_tiles_y_ = ComputeNumTiles(
       max_texture_size_.height(), total_size_.height(), border_texels_);
 }
 
 TilingData::BaseIterator::BaseIterator(const TilingData* tiling_data)
     : tiling_data_(tiling_data),
       index_x_(-1),
       index_y_(-1) {
 }
 
-TilingData::Iterator::Iterator(const TilingData* tiling_data, gfx::Rect rect)
+TilingData::Iterator::Iterator(const TilingData* tiling_data,
+                               const gfx::Rect& tiling_rect)
     : BaseIterator(tiling_data),
       left_(-1),
       right_(-1),
       bottom_(-1) {
   if (tiling_data_->num_tiles_x() <= 0 || tiling_data_->num_tiles_y() <= 0) {
     done();
     return;
   }
 
+  gfx::Rect rect(tiling_rect);
   rect.Intersect(gfx::Rect(tiling_data_->total_size()));
   index_x_ = tiling_data_->FirstBorderTileXIndexFromSrcCoord(rect.x());
   index_y_ = tiling_data_->FirstBorderTileYIndexFromSrcCoord(rect.y());
   left_ = index_x_;
   right_ = tiling_data_->LastBorderTileXIndexFromSrcCoord(rect.right() - 1);
   bottom_ = tiling_data_->LastBorderTileYIndexFromSrcCoord(rect.bottom() - 1);
 
   // Index functions always return valid indices, so explicitly check
   // for non-intersecting rects.
   gfx::Rect new_rect = tiling_data_->TileBoundsWithBorder(index_x_, index_y_);
@@ skipping 11 matching lines @@
     index_y_++;
     if (index_y_ > bottom_)
       done();
   }
 
   return *this;
 }
 
 TilingData::DifferenceIterator::DifferenceIterator(
     const TilingData* tiling_data,
-    gfx::Rect consider,
-    gfx::Rect ignore)
+    const gfx::Rect& consider_rect,
+    const gfx::Rect& ignore_rect)
     : BaseIterator(tiling_data),
       consider_left_(-1),
       consider_top_(-1),
       consider_right_(-1),
       consider_bottom_(-1),
       ignore_left_(-1),
       ignore_top_(-1),
       ignore_right_(-1),
       ignore_bottom_(-1) {
   if (tiling_data_->num_tiles_x() <= 0 || tiling_data_->num_tiles_y() <= 0) {
     done();
     return;
   }
 
   gfx::Rect bounds(tiling_data_->total_size());
+  gfx::Rect consider(consider_rect);
+  gfx::Rect ignore(ignore_rect);
   consider.Intersect(bounds);
   ignore.Intersect(bounds);
   if (consider.IsEmpty()) {
     done();
     return;
   }
 
   consider_left_ =
       tiling_data_->FirstBorderTileXIndexFromSrcCoord(consider.x());
   consider_top_ =
@@ skipping 56 matching lines @@
     }
 
     if (index_y_ > consider_bottom_)
       done();
   }
 
   return *this;
 }
 
 }  // namespace cc