Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 93663002: Run ipc_tests serially when using new test launcher. (Closed)

Created:
7 years ago by Paweł Hajdan Jr.
Modified:
7 years ago
Reviewers:
jeremy
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Run ipc_tests serially when using new test launcher. On Windows they would hit resource contention issues otherwise and run slower than serially. Run time is in seconds anyway. BUG=236893 R=jeremy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238251

Patch Set 1 #

Patch Set 2 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M base/test/launcher/unit_test_launcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 3 chunks +20 lines, -6 lines 0 comments Download
M ipc/ipc.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
A + ipc/run_all_unittests.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years ago (2013-11-28 03:03:23 UTC) #1
jeremy
LGTM
7 years ago (2013-11-28 12:17:39 UTC) #2
Paweł Hajdan Jr.
7 years ago (2013-12-03 00:50:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r238251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698