Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 936613006: The expected key is a valid identifier, which is already free of \\, <0x20, ". (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

The expected key is a valid identifier, which is already free of \\, <0x20, ". BUG= Committed: https://crrev.com/69ecbc75b8a09ff9a738fa95df0b34596fb998b0 Cr-Commit-Position: refs/heads/master@{#26725}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/json-parser.h View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-18 13:11:24 UTC) #2
Yang
On 2015/02/18 13:11:24, Toon Verwaest wrote: > PTAL Lgtm.
5 years, 10 months ago (2015-02-18 15:12:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936613006/20001
5 years, 10 months ago (2015-02-18 15:26:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 15:48:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 15:48:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69ecbc75b8a09ff9a738fa95df0b34596fb998b0
Cr-Commit-Position: refs/heads/master@{#26725}

Powered by Google App Engine
This is Rietveld 408576698