Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 936603003: Enumerate HID devices asynchronously on Windows. (Closed)

Created:
5 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enumerate HID devices asynchronously on Windows. Avoid possibly long blocking times in the Windows SetupDi function calls made to enumerate devices by offloading to the FILE thread. Now that we can be sure that a stray request to the device won't block the UI additional calls to get the device's product and serial number strings can be made. BUG=457899 Committed: https://crrev.com/8c5a2c5f3c9efbc0c5810e8269d788210175a6af Cr-Commit-Position: refs/heads/master@{#316939}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use "OnFileThread" suffix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -15 lines) Patch
M device/hid/hid_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_win.h View 1 4 chunks +12 lines, -3 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 6 chunks +61 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Ken, please take a look at this patch.
5 years, 10 months ago (2015-02-18 00:16:12 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/936603003/diff/1/device/hid/hid_service_win.h File device/hid/hid_service_win.h (right): https://codereview.chromium.org/936603003/diff/1/device/hid/hid_service_win.h#newcode42 device/hid/hid_service_win.h:42: static void InitialEnumerationFileThread( nit: Judging from its ubiquity ...
5 years, 10 months ago (2015-02-18 20:40:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936603003/20001
5 years, 10 months ago (2015-02-18 20:59:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 00:53:09 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 00:53:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c5a2c5f3c9efbc0c5810e8269d788210175a6af
Cr-Commit-Position: refs/heads/master@{#316939}

Powered by Google App Engine
This is Rietveld 408576698