Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936583002: SK_NO_FLATE (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SK_NO_FLATE Also remove skia_zlib_static. We're not using it. We don't even have zlib in DEPS. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/1e4e814c0396a2e1a283e2661c04e6b12eeb5265

Patch Set 1 #

Patch Set 2 : NO_FLATE #

Patch Set 3 : drop skia_zlib_static #

Patch Set 4 : fix and simplify #

Patch Set 5 : no source #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -96 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +1 line, -0 lines 1 comment Download
M gyp/common_variables.gypi View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M gyp/zlib.gyp View 1 2 3 4 1 chunk +9 lines, -70 lines 0 comments Download
M include/config/SkUserConfig.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkFlate.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M tests/FlateTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
mtklein_C
5 years, 10 months ago (2015-02-17 20:58:49 UTC) #2
hal.canary
https://codereview.chromium.org/936583002/diff/80001/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/936583002/diff/80001/gyp/common_conditions.gypi#newcode42 gyp/common_conditions.gypi:42: 'SK_NO_FLATE', # Too much of a pain to set ...
5 years, 10 months ago (2015-02-17 21:01:34 UTC) #3
mtklein
> https://codereview.chromium.org/936583002/diff/80001/gyp/common_conditions.gypi#newcode42 > gyp/common_conditions.gypi:42: 'SK_NO_FLATE', # Too much of a pain to set up > ...
5 years, 10 months ago (2015-02-17 21:02:32 UTC) #4
hal.canary
LGTM.
5 years, 10 months ago (2015-02-17 21:03:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936583002/80001
5 years, 10 months ago (2015-02-17 21:04:28 UTC) #7
hal.canary
On 2015/02/17 21:03:18, Hal Canary wrote: > LGTM. I'm trying this on mu macbook, I ...
5 years, 10 months ago (2015-02-17 21:04:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936583002/80001
5 years, 10 months ago (2015-02-17 21:04:48 UTC) #11
mtklein
On 2015/02/17 21:04:47, Hal Canary wrote: > On 2015/02/17 21:03:18, Hal Canary wrote: > > ...
5 years, 10 months ago (2015-02-17 21:05:30 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/1e4e814c0396a2e1a283e2661c04e6b12eeb5265
5 years, 10 months ago (2015-02-17 21:10:48 UTC) #13
reed2
On 2015/02/17 21:10:48, I haz the power (commit-bot) wrote: > Committed patchset #5 (id:80001) as ...
5 years, 10 months ago (2015-02-18 03:06:18 UTC) #14
mtklein
5 years, 10 months ago (2015-02-18 03:17:55 UTC) #15
Message was sent while issue was closed. 
On 2015/02/18 03:06:18, reed2 wrote:
> On 2015/02/17 21:10:48, I haz the power (commit-bot) wrote:
> > Committed patchset #5 (id:80001) as
> >
https://skia.googlesource.com/skia/+/1e4e814c0396a2e1a283e2661c04e6b12eeb5265
> 
> SampleApp does not link for me in XCode -- missing symbols for zlib I think
> (e.g. _deflate).

Hmm.  That's weird.  It works for me and the bots.  We can certainly go back to
the old way, but it's nice if we can to configure Macs normally like '-lz'
instead of '$(SDKROOT)/usr/lib/libz.dylib'.

Can you `ls /usr/lib` for me?  If it's empty, try opening up XCode, opening
Preferences, and under Locations make sure Command Line Tools is set up?

Powered by Google App Engine
This is Rietveld 408576698