Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: remoting/host/video_frame_pump.cc

Issue 936553003: Fix VideoFramePump to send keep-alive packets only after the first real frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/client_session_unittest.cc ('k') | tools/valgrind/gtest_exclude/remoting_unittests.gtest.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/video_frame_pump.cc
diff --git a/remoting/host/video_frame_pump.cc b/remoting/host/video_frame_pump.cc
index 1f11264b786e180eb4e2154a96629600d72a3068..6451313af3e560ac0271091dba7b0c00d3307fcc 100644
--- a/remoting/host/video_frame_pump.cc
+++ b/remoting/host/video_frame_pump.cc
@@ -60,7 +60,12 @@ VideoFramePump::VideoFramePump(
capturer_(capturer.Pass()),
encoder_(encoder.Pass()),
video_stub_(video_stub),
- keep_alive_timer_(true, true),
+ keep_alive_timer_(
+ FROM_HERE,
+ base::TimeDelta::FromMilliseconds(kKeepAlivePacketIntervalMs),
+ base::Bind(&VideoFramePump::SendKeepAlivePacket,
+ base::Unretained(this)),
+ false),
Wez 2015/02/18 22:59:35 You've changed this from repeating to non-repeatin
Sergey Ulanov 2015/02/18 23:31:41 Yes - it's mentioned in the CL description. It's n
capture_scheduler_(base::Bind(&VideoFramePump::CaptureNextFrame,
base::Unretained(this))),
latest_event_timestamp_(0),
@@ -70,10 +75,6 @@ VideoFramePump::VideoFramePump(
capturer_->Start(this);
capture_scheduler_.Start();
-
- keep_alive_timer_.Start(
- FROM_HERE, base::TimeDelta::FromMilliseconds(kKeepAlivePacketIntervalMs),
- base::Bind(&VideoFramePump::SendKeepAlivePacket, base::Unretained(this)));
}
VideoFramePump::~VideoFramePump() {
« no previous file with comments | « remoting/host/client_session_unittest.cc ('k') | tools/valgrind/gtest_exclude/remoting_unittests.gtest.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698