Issue 936503003: Add TypeChecking=Unrestricted to Element and Window interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 936503003: Add TypeChecking=Unrestricted to Element and Window interfaces (Closed)

Created:
5 years, 10 months ago by fs

Modified:
5 years, 10 months ago

Reviewers:
philipj_slow, Rick Byers

CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add TypeChecking=Unrestricted to Element and Window interfaces Affects Element.scrollLeft/Top and Element/Window.scroll{,By,To}. Matches CSSOM View, but no change in behavior or generated code. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190381

Patch Set 1 #

Patch Set 2 : Added Window too. #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	Source/core/dom/Element.idl	View		2 chunks	+8 lines, -6 lines	0 comments	Download
	M	Source/core/frame/Window.idl	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936503003/20001

5 years, 10 months ago (2015-02-18 03:10:57 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-18 03:25:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190381

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages