Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 936503002: SigninManager owns ObserverList for the MergeSessionHelper. (Closed)

Created:
5 years, 10 months ago by Mike Lerman
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SigninManager owns ObserverList for the MergeSessionHelper. BUG=458903 TEST=You can sign into chrome, and your signin credential also gets pushed into the cookie jar (for gmail). Also, if you re-auth in the browser after changing your password, your signin credential for the content area still also (still) gets updated. Committed: https://crrev.com/2ce480a20c0487af08240bd03865f824d38edd2c Cr-Commit-Position: refs/heads/master@{#316606}

Patch Set 1 #

Patch Set 2 : Override! Override! (toro! toro!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M components/signin/core/browser/signin_manager.h View 1 3 chunks +12 lines, -1 line 0 comments Download
M components/signin/core/browser/signin_manager.cc View 3 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike Lerman
Hi Roger, Here's the fix for the issue around the MergeSessionHelper observing we discuss this ...
5 years, 10 months ago (2015-02-17 16:25:29 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 10 months ago (2015-02-17 16:50:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936503002/20001
5 years, 10 months ago (2015-02-17 17:32:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 18:04:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:04:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ce480a20c0487af08240bd03865f824d38edd2c
Cr-Commit-Position: refs/heads/master@{#316606}

Powered by Google App Engine
This is Rietveld 408576698