Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: Source/core/dom/ScriptLoader.h

Issue 936493003: Revert of Teach ScriptRunner how to yield and post on loading task queue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/ScriptRunner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ScriptLoader.h
diff --git a/Source/core/dom/ScriptLoader.h b/Source/core/dom/ScriptLoader.h
index 8ebdb30f86b21ce1a8804078344dfd56a67ddc22..7353578977e0ba5ac5f0a30f866a61192cb014d6 100644
--- a/Source/core/dom/ScriptLoader.h
+++ b/Source/core/dom/ScriptLoader.h
@@ -36,7 +36,7 @@
class ScriptSourceCode;
-class ScriptLoader : public NoBaseWillBeGarbageCollectedFinalized<ScriptLoader>, private ScriptResourceClient {
+class ScriptLoader final : public NoBaseWillBeGarbageCollectedFinalized<ScriptLoader>, private ScriptResourceClient {
public:
static PassOwnPtrWillBeRawPtr<ScriptLoader> create(Element* element, bool createdByParser, bool isEvaluated)
{
@@ -54,7 +54,7 @@
String scriptCharset() const { return m_characterEncoding; }
String scriptContent() const;
void executeScript(const ScriptSourceCode&, double* compilationFinishTime = 0);
- virtual void execute();
+ void execute();
// XML parser calls these
void dispatchLoadEvent();
@@ -78,15 +78,14 @@
void handleSourceAttribute(const String& sourceUrl);
void handleAsyncAttribute();
- virtual bool isReady() const { return m_pendingScript.isReady(); }
+ bool isReady() const { return m_pendingScript.isReady(); }
// Clears the connection to the PendingScript (and Element and Resource).
void detach();
-protected:
+private:
ScriptLoader(Element*, bool createdByParser, bool isEvaluated);
-private:
bool ignoresLoadRequest() const;
bool isScriptForEventSupported() const;
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/ScriptRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698