Issue 936493003: Revert of Teach ScriptRunner how to yield and post on loading task queue

Issue 936493003: Revert of Teach ScriptRunner how to yield and post on loading task queue (Closed)

Created:
5 years, 10 months ago by alex clarke (OOO till 29th)

Modified:
5 years, 10 months ago

Reviewers:
sof, Sami, marja

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, oilpan-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Teach ScriptRunner how to yield and post on loading task queue (patchset #10 id:260001 of https://codereview.chromium.org/866273005/) Reason for revert: Looks like this was causing oilpan leaks Original issue's description: > Teach ScriptRunner how to yield > > Previously ScriptRunner could execute an arbitrary number of scripts > leading to janks. Now ScriptRunner polls shouldYieldForHighPriorityWork > before running each script. > > In addition the task to execute the scripts is now posted on the > loading task queue. > > BUG=456777 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190648 TBR=skyostil@chromium.org,marja@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456777 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190661

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -531 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/ScriptLoader.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	Source/core/dom/ScriptRunner.h	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	Source/core/dom/ScriptRunner.cpp	View	4 chunks	+19 lines, -47 lines	0 comments	Download
D	Source/core/dom/ScriptRunnerTest.cpp	View	1 chunk	+0 lines, -468 lines	0 comments	Download

Total messages: 4 (0 generated)

alex clarke (OOO till 29th)

Created Revert of Teach ScriptRunner how to yield and post on loading task queue

5 years, 10 months ago (2015-02-23 14:24:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936493003/1

5 years, 10 months ago (2015-02-23 14:25:06 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190661

5 years, 10 months ago (2015-02-23 14:25:32 UTC) #3

sof

5 years, 10 months ago (2015-02-23 15:55:33 UTC) #4

Message was sent while issue was closed.

Many thanks for reverting until this detail has been dealt with; we appreciate
the Oilpan help :)