Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936483002: Bring back the domain gating check for settings protection. (Closed)

Created:
5 years, 10 months ago by gab
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@908473002_ps2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bring back the domain gating check for settings protection. This is effectively a revert of http://crrev.com/297947 while a better long term solution is put together. BUG=325447, 455647 Committed: https://crrev.com/bcdefd0ccb889e082823cd32e7469a3ffc0972df Cr-Commit-Position: refs/heads/master@{#316610}

Patch Set 1 #

Patch Set 2 : fix test compile #

Total comments: 2

Patch Set 3 : update histogram description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 3 chunks +32 lines, -2 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
gab
@Robert: PTAL. @Alexei: PTAL @ histograms (in particular can I unobsolete a histogram that was ...
5 years, 10 months ago (2015-02-17 15:18:02 UTC) #2
robertshield
Changes here lgtm. Defer to other reviewers for your specific questions.
5 years, 10 months ago (2015-02-17 15:41:01 UTC) #3
Jeffrey Yasskin
lgtm for extensions
5 years, 10 months ago (2015-02-17 16:20:36 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/936483002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/936483002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode33344 tools/metrics/histograms/histograms.xml:33344: - Deprecated 2014-10. Nit: Maybe mention in the ...
5 years, 10 months ago (2015-02-17 16:35:20 UTC) #5
gab
https://codereview.chromium.org/936483002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/936483002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode33344 tools/metrics/histograms/histograms.xml:33344: - Deprecated 2014-10. On 2015/02/17 16:35:20, Alexei Svitkine wrote: ...
5 years, 10 months ago (2015-02-17 17:04:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936483002/40001
5 years, 10 months ago (2015-02-17 17:05:49 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 18:12:50 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:13:45 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bcdefd0ccb889e082823cd32e7469a3ffc0972df
Cr-Commit-Position: refs/heads/master@{#316610}

Powered by Google App Engine
This is Rietveld 408576698