Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 936423002: Revert of notify resource caches when pixelref genID goes stale (Closed)

Created:
5 years, 10 months ago by mtklein
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of notify resource caches when pixelref genID goes stale (patchset #4 id:60001 of https://codereview.chromium.org/825263005/) Reason for revert: Crazy failures. http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/builds/1428/steps/dm/logs/stdio Original issue's description: > notify resource caches when pixelref genID goes stale > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4675819b9dbb3ad71ec851776e5de26d342f29fe TBR=bsalomon@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/90c6bc4e85df2da37f436ea1da203e194c4740e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -231 lines) Patch
M src/core/SkBitmapCache.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/core/SkBitmapCache.cpp View 10 chunks +18 lines, -66 lines 0 comments Download
M src/core/SkPixelRef.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
M src/core/SkResourceCache.h View 7 chunks +3 lines, -35 lines 0 comments Download
M src/core/SkResourceCache.cpp View 4 chunks +2 lines, -37 lines 0 comments Download
M tests/SkResourceCacheTest.cpp View 3 chunks +1 line, -72 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of notify resource caches when pixelref genID goes stale
5 years, 10 months ago (2015-02-19 16:53:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936423002/1
5 years, 10 months ago (2015-02-19 16:53:44 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 16:53:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/90c6bc4e85df2da37f436ea1da203e194c4740e2

Powered by Google App Engine
This is Rietveld 408576698