Allow extensions of the ManifestParser outside of the content/ layer.

content/renderer/manifest/manifest_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/manifest/manifest_manager.h"
 
 #include "base/bind.h"
 #include "base/strings/nullable_string16.h"
 #include "content/common/manifest_manager_messages.h"
 #include "content/public/renderer/document_state.h"
+#include "content/public/renderer/manifest_parser.h"
 #include "content/public/renderer/navigation_state.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/renderer/fetchers/manifest_fetcher.h"
-#include "content/renderer/manifest/manifest_parser.h"
 #include "content/renderer/manifest/manifest_uma_util.h"
 #include "third_party/WebKit/public/platform/WebURLResponse.h"
 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 
 namespace content {
 
 ManifestManager::ManifestManager(RenderFrame* render_frame)
     : RenderFrameObserver(render_frame),
@@ skipping 109 matching lines @@
     const blink::WebURLResponse& response,
     const std::string& data) {
   if (response.isNull() && data.empty()) {
     ManifestUmaUtil::FetchFailed(ManifestUmaUtil::FETCH_UNSPECIFIED_REASON);
     ResolveCallbacks(ResolveStateFailure);
     return;
   }
 
   ManifestUmaUtil::FetchSucceeded();
 
-  ManifestParser parser(data, response.url(), document_url);
-  parser.Parse();
+  scoped_ptr<ManifestParser> parser = ManifestParser::Get();
+  parser->Parse(data, response.url(), document_url);
 
   fetcher_.reset();
 
-  for (const std::string& msg : parser.errors()) {
+  for (const std::string& msg : parser->errors()) {
     blink::WebConsoleMessage message;
     message.level = blink::WebConsoleMessage::LevelError;
     message.text = blink::WebString::fromUTF8(msg);
     render_frame()->GetWebFrame()->addMessageToConsole(message);
   }
 
   // Having errors while parsing the manifest doesn't mean the manifest parsing
   // failed. Some properties might have been ignored but some others kept.
-  if (parser.failed()) {
+  if (parser->failed()) {
     ResolveCallbacks(ResolveStateFailure);
     return;
   }
 
-  manifest_ = parser.manifest();
+  manifest_ = parser->manifest();
   ResolveCallbacks(ResolveStateSuccess);
 }
 
 void ManifestManager::ResolveCallbacks(ResolveState state) {
   if (state == ResolveStateFailure)
     manifest_ = Manifest();
 
   manifest_dirty_ = state != ResolveStateSuccess;
 
   Manifest manifest = manifest_;
   std::list<GetManifestCallback> callbacks = pending_callbacks_;
 
   pending_callbacks_.clear();
 
   for (std::list<GetManifestCallback>::const_iterator it = callbacks.begin();
        it != callbacks.end(); ++it) {
     it->Run(manifest);
   }
 }
 
 } // namespace content