PDF: why do we have flags no one uses (or can use)?

src/pdf/SkPDFStream.cpp

 
 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkData.h"
 #include "SkFlate.h"
 #include "SkPDFCatalog.h"
 #include "SkPDFStream.h"
 #include "SkStream.h"
 #include "SkStreamPriv.h"
 
-static bool skip_compression(SkPDFCatalog* catalog) {
-    return SkToBool(catalog->getDocumentFlags() &
-                    SkPDFDocument::kFavorSpeedOverSize_Flags);
-}
-
 SkPDFStream::SkPDFStream(SkStream* stream) : fState(kUnused_State) {
     this->setData(stream);
 }
 
 SkPDFStream::SkPDFStream(SkData* data) : fState(kUnused_State) {
     this->setData(data);
 }
 
 SkPDFStream::SkPDFStream(const SkPDFStream& pdfStream)
         : SkPDFDict(),
@@ skipping 55 matching lines @@
     if (fState == kUnused_State) {
         fState = kNoCompression_State;
         insertInt("Length", this->dataSize());
     }
     return true;
 
 #else  // !SK_NO_FLATE
 
     if (fState == kUnused_State) {
         fState = kNoCompression_State;
-        if (!skip_compression(catalog)) {
-            SkDynamicMemoryWStream compressedData;
+        SkDynamicMemoryWStream compressedData;
 
-            SkAssertResult(
-                    SkFlate::Deflate(fDataStream.get(), &compressedData));
-            SkAssertResult(fDataStream->rewind());
-            if (compressedData.getOffset() < this->dataSize()) {
-                SkAutoTDelete<SkStream> compressed(
-                        compressedData.detachAsStream());
-                this->setData(compressed.get());
-                insertName("Filter", "FlateDecode");
-            }
-            fState = kCompressed_State;
-        } else {
-            fState = kNoCompression_State;
+        SkAssertResult(
+                SkFlate::Deflate(fDataStream.get(), &compressedData));
+        SkAssertResult(fDataStream->rewind());
+        if (compressedData.getOffset() < this->dataSize()) {
+            SkAutoTDelete<SkStream> compressed(
+                    compressedData.detachAsStream());
+            this->setData(compressed.get());
+            insertName("Filter", "FlateDecode");
         }
+        fState = kCompressed_State;
         insertInt("Length", this->dataSize());
     }
-    else if (fState == kNoCompression_State && !skip_compression(catalog)) {
+    else if (fState == kNoCompression_State) {
         if (!fSubstitute.get()) {
             fSubstitute.reset(new SkPDFStream(*this));
             catalog->setSubstitute(this, fSubstitute.get());
         }
         return false;
     }
     return true;
 #endif  // SK_NO_FLATE
 }