Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936373002: Remove unused function WebContentsDelegate::DidNavigateToPendingEntry. (Closed)

Created:
5 years, 10 months ago by christiank
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused function WebContentsDelegate::DidNavigateToPendingEntry. DidNavigateToPendingEntry is no longer used and can be removed. BUG= Committed: https://crrev.com/bcaee2f8da9d374ebcc51cb997484befa0580920 Cr-Commit-Position: refs/heads/master@{#317574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 chunk +0 lines, -4 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
christiank
Hi, I noticed that WebContentsDelegate::DidNavigateToPendingEntry is no longer called by anyone so I though I ...
5 years, 10 months ago (2015-02-19 13:39:20 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-23 09:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936373002/1
5 years, 10 months ago (2015-02-23 11:00:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 12:37:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 12:38:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bcaee2f8da9d374ebcc51cb997484befa0580920
Cr-Commit-Position: refs/heads/master@{#317574}

Powered by Google App Engine
This is Rietveld 408576698