Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936343002: Simplify computation of environment stack delta. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify computation of environment stack delta. R=titzer@chromium.org TEST=cctest/test-run-jsexceptions/CatchCall Committed: https://crrev.com/6fe12676ce3903946fbb0cd632d79a7d87af41b7 Cr-Commit-Position: refs/heads/master@{#26768}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Ben Titzer. #

Patch Set 3 : Rebased and slightly better test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 15 chunks +21 lines, -23 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-19 12:22:02 UTC) #1
titzer
lgtm https://codereview.chromium.org/936343002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/936343002/diff/1/src/compiler/ast-graph-builder.cc#newcode684 src/compiler/ast-graph-builder.cc:684: if (stack_delta > 0) environment()->Drop(stack_delta); environment()->TrimStack() ?
5 years, 10 months ago (2015-02-19 12:33:00 UTC) #2
Michael Starzinger
https://codereview.chromium.org/936343002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/936343002/diff/1/src/compiler/ast-graph-builder.cc#newcode684 src/compiler/ast-graph-builder.cc:684: if (stack_delta > 0) environment()->Drop(stack_delta); On 2015/02/19 12:33:00, titzer ...
5 years, 10 months ago (2015-02-19 12:58:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936343002/40001
5 years, 10 months ago (2015-02-20 10:32:30 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-20 10:48:11 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 10:48:32 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6fe12676ce3903946fbb0cd632d79a7d87af41b7
Cr-Commit-Position: refs/heads/master@{#26768}

Powered by Google App Engine
This is Rietveld 408576698