Created optional multiprofiles introduction dialog.

chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc

Index: chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc
diff --git a/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc b/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc
new file mode 100644
index 0000000000000000000000000000000000000000..df08e2a6c55b0d7bb4e874cac984d48ebb8ed3f4
--- /dev/null
+++ b/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc
@@ -0,0 +1,152 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.h"
+
+#include "ash/shell.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/views/controls/button/checkbox.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/layout/grid_layout.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace chromeos {
+
+namespace {
+
+// Default width/height of the dialog.
+const int kDefaultWidth = 600;
+const int kDefaultHeight = 250;
+
+const int kPaddingToMessage = 20;
+const int kPaddingToCheckBox = 50;
+const gfx::Insets kInsets = gfx::Insets(40, 40, 40, 40);

[oshima, 2014/01/10 19:14:07]

non POD global object is not allowed. You may move inside the function with
static const though

[merkulova, 2014/01/14 09:55:58]

Done.

[merkulova, 2014/01/16 10:24:01]

Hi, Oshima.
On committing I discovered that non POD static objects are not allowed.
Compilation logs
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos_clang/...

So I just changed it to const. Insets object creation isn't heavy, so I think it
would be better than applying  CR_DEFINE_STATIC_LOCAL. 

+
+////////////////////////////////////////////////////////////////////////////////
+// Dialog for multi-profiles introduction.
+class MultiprofilesIntroView : public views::DialogDelegateView {
+ public:
+  MultiprofilesIntroView(base::Callback<void(bool)> on_accept);

[oshima, 2014/01/10 19:14:07]

explicit

[merkulova, 2014/01/14 09:55:58]

Done.

+  virtual ~MultiprofilesIntroView();
+
+  static void ShowDialog(base::Callback<void(bool)> on_accept);
+
+  virtual bool Accept() OVERRIDE;
+
+  // views::WidgetDelegate overrides
+  virtual ui::ModalType GetModalType() const OVERRIDE;
+
+  // views::View overrides
+  virtual gfx::Size GetPreferredSize() OVERRIDE;
+
+ private:
+  void InitDialog();
+
+  scoped_ptr<views::Checkbox> no_show_checkbox_;
+  base::Callback<void(bool)> on_accept_;

[oshima, 2014/01/10 19:14:07]

can this be const?

[merkulova, 2014/01/14 09:55:58]

Done.

+};

[oshima, 2014/01/10 19:14:07]

DISALLOW_COPY_AND_ASSIGN

[merkulova, 2014/01/14 09:55:58]

Done.

+
+////////////////////////////////////////////////////////////////////////////////
+// MultiprofilesIntroDialog implementation.
+
+MultiprofilesIntroView::MultiprofilesIntroView(
+    base::Callback<void(bool)> on_accept) : on_accept_(on_accept){
+}
+
+MultiprofilesIntroView::~MultiprofilesIntroView() {
+}
+
+// static
+void MultiprofilesIntroView::ShowDialog(base::Callback<void(bool)> on_accept) {
+  MultiprofilesIntroView* dialog_view =
+      new MultiprofilesIntroView(on_accept);
+  views::DialogDelegate::CreateDialogWidget(
+      dialog_view, ash::Shell::GetPrimaryRootWindow(), NULL);
+  dialog_view->InitDialog();
+  views::Widget* widget = dialog_view->GetWidget();
+  DCHECK(widget);
+  widget->Show();
+}
+
+bool MultiprofilesIntroView::Accept() {
+  on_accept_.Run(no_show_checkbox_->checked());
+  return true;
+}
+
+ui::ModalType MultiprofilesIntroView::GetModalType() const {
+  return ui::MODAL_TYPE_SYSTEM;
+}
+
+gfx::Size MultiprofilesIntroView::GetPreferredSize() {
+  return gfx::Size(kDefaultWidth, kDefaultHeight);
+}
+
+void MultiprofilesIntroView::InitDialog() {
+  // Create the views and layout manager and set them up.
+  views::GridLayout* grid_layout = views::GridLayout::CreatePanel(this);
+  grid_layout->SetInsets(kInsets);
+
+  views::ColumnSet* column_set = grid_layout->AddColumnSet(0);
+  column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
+                        views::GridLayout::USE_PREF, 0, 0);
+
+  views::Label* title_label_ = new views::Label(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_HEADLINE));
+  title_label_->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumBoldFont));
+  title_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);

[oshima, 2014/01/10 19:14:07]

Any RTL/i18n issue here?

[merkulova, 2014/01/14 09:55:58]

It will automatically mirror the dialog for RTL locale.
So, no additional alignment changes required.

+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(title_label_);
+  grid_layout->AddPaddingRow(0, kPaddingToMessage);
+
+  // Explanation string
+  views::Label* label = new views::Label(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_MESSAGE));
+  label->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumFont));
+  label->SetMultiLine(true);
+  label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  label->SetAllowCharacterBreak(true);
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(label);
+
+  // Next explanation string
+  grid_layout->AddPaddingRow(0, kPaddingToMessage);
+  views::Label* lower_label = new views::Label(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_EXPLANATION));
+  lower_label->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumFont));
+  lower_label->SetMultiLine(true);
+  lower_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  lower_label->SetAllowCharacterBreak(true);
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(lower_label);
+
+  // No-show again checkbox
+  grid_layout->AddPaddingRow(0, kPaddingToCheckBox);
+  no_show_checkbox_.reset(new views::Checkbox(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_NOSHOW_AGAIN)));
+  no_show_checkbox_->SetChecked(true);
+  no_show_checkbox_->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumFont));
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(no_show_checkbox_.get());
+
+  SetLayoutManager(grid_layout);
+  Layout();
+}
+
+}  // namespace
+
+////////////////////////////////////////////////////////////////////////////////
+// Factory function.
+
+void ShowMultiprofilesIntroDialog(base::Callback<void(bool)> on_accept) {
+  MultiprofilesIntroView::ShowDialog(on_accept);
+}
+
+}  // namespace chromeos