Created optional multiprofiles introduction dialog.

chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.h"
+
+#include "ash/shell.h"
+#include "base/i18n/rtl.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/views/controls/button/checkbox.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/layout/grid_layout.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace chromeos {
+
+namespace {
+
+// Default width/height of the dialog.
+const int kDefaultWidth = 600;
+const int kDefaultHeight = 250;
+
+const int kPaddingToMessage = 20;
+const int kPaddingToCheckBox = 50;
+const int kInset = 40;
+
+////////////////////////////////////////////////////////////////////////////////
+// Dialog for multi-profiles introduction.
+class MultiprofilesIntroView : public views::DialogDelegateView {
+ public:
+  explicit MultiprofilesIntroView(const base::Callback<void(bool)> on_accept);
+  virtual ~MultiprofilesIntroView();
+
+  static void ShowDialog(const base::Callback<void(bool)> on_accept);
+
+  virtual bool Accept() OVERRIDE;

[Nikita (slow), 2014/01/14 13:44:11]

nit: // views::DialogDelegate overrides.

[merkulova, 2014/01/14 14:29:34]

Done.

+
+  // views::WidgetDelegate overrides

[Nikita (slow), 2014/01/14 13:44:11]

nit: Add dot at each comment sentence (here and below).

[merkulova, 2014/01/14 14:29:34]

Done.

+  virtual ui::ModalType GetModalType() const OVERRIDE;
+
+  // views::View overrides
+  virtual gfx::Size GetPreferredSize() OVERRIDE;
+
+ private:
+  void InitDialog();
+
+  scoped_ptr<views::Checkbox> no_show_checkbox_;
+  const base::Callback<void(bool)> on_accept_;
+
+  static const gfx::Insets dialogInsets;
+
+  DISALLOW_COPY_AND_ASSIGN(MultiprofilesIntroView);
+};
+
+const gfx::Insets MultiprofilesIntroView::dialogInsets(kInset, kInset,
+                                                       kInset, kInset);
+
+////////////////////////////////////////////////////////////////////////////////
+// MultiprofilesIntroDialog implementation.
+
+MultiprofilesIntroView::MultiprofilesIntroView(
+    const base::Callback<void(bool)> on_accept) : on_accept_(on_accept) {
+}
+
+MultiprofilesIntroView::~MultiprofilesIntroView() {
+}
+
+// static
+void MultiprofilesIntroView::ShowDialog(
+    const base::Callback<void(bool)> on_accept) {
+  MultiprofilesIntroView* dialog_view =
+      new MultiprofilesIntroView(on_accept);
+  views::DialogDelegate::CreateDialogWidget(
+      dialog_view, ash::Shell::GetPrimaryRootWindow(), NULL);
+  dialog_view->InitDialog();
+  views::Widget* widget = dialog_view->GetWidget();
+  DCHECK(widget);
+  widget->Show();
+}
+
+bool MultiprofilesIntroView::Accept() {
+  on_accept_.Run(no_show_checkbox_->checked());
+  return true;
+}
+
+ui::ModalType MultiprofilesIntroView::GetModalType() const {
+  return ui::MODAL_TYPE_SYSTEM;
+}
+
+gfx::Size MultiprofilesIntroView::GetPreferredSize() {
+  return gfx::Size(kDefaultWidth, kDefaultHeight);
+}
+
+void MultiprofilesIntroView::InitDialog() {

[Nikita (slow), 2014/01/14 13:44:11]

Please make layout RTL friendly.

[merkulova, 2014/01/14 14:29:34]

It is already friendly. The dialog is automatically mirrored for RTL languages.
If I set it manually, I get it wrong.

+  // Create the views and layout manager and set them up.
+  views::GridLayout* grid_layout = views::GridLayout::CreatePanel(this);
+  grid_layout->SetInsets(MultiprofilesIntroView::dialogInsets);
+
+  views::ColumnSet* column_set = grid_layout->AddColumnSet(0);
+  column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
+                        views::GridLayout::USE_PREF, 0, 0);
+
+  views::Label* title_label_ = new views::Label(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_HEADLINE));
+  title_label_->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumBoldFont));
+  title_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(title_label_);
+  grid_layout->AddPaddingRow(0, kPaddingToMessage);
+
+  // Explanation string

[Nikita (slow), 2014/01/14 13:44:11]

nit: Dot at the and here and below.

[merkulova, 2014/01/14 14:29:34]

Done.

+  views::Label* label = new views::Label(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_MESSAGE));
+  label->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumFont));
+  label->SetMultiLine(true);
+  label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  label->SetAllowCharacterBreak(true);
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(label);
+
+  // Next explanation string
+  grid_layout->AddPaddingRow(0, kPaddingToMessage);
+  views::Label* lower_label = new views::Label(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_EXPLANATION));
+  lower_label->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumFont));
+  lower_label->SetMultiLine(true);
+  lower_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  lower_label->SetAllowCharacterBreak(true);
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(lower_label);
+
+  // No-show again checkbox
+  grid_layout->AddPaddingRow(0, kPaddingToCheckBox);
+  no_show_checkbox_.reset(new views::Checkbox(
+      l10n_util::GetStringUTF16(IDS_MULTIPROFILES_INTRO_NOSHOW_AGAIN)));
+  no_show_checkbox_->SetChecked(true);
+  no_show_checkbox_->SetFont(ui::ResourceBundle::GetSharedInstance().GetFont(
+      ui::ResourceBundle::MediumFont));
+  no_show_checkbox_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  grid_layout->StartRow(0, 0);
+  grid_layout->AddView(no_show_checkbox_.get());
+
+  SetLayoutManager(grid_layout);
+  Layout();

[Nikita (slow), 2014/01/14 13:44:11]

nit: I don't think that you need to call Layout() explicitly here.
Please check that it still works fine without this call.

[merkulova, 2014/01/14 14:29:34]

It is necessary actually. Without this call, we get only clear dialog without
any labels, checkboxes and so on.

+}
+
+}  // namespace
+
+////////////////////////////////////////////////////////////////////////////////
+// Factory function.
+
+void ShowMultiprofilesIntroDialog(const base::Callback<void(bool)> on_accept) {
+  MultiprofilesIntroView::ShowDialog(on_accept);
+}
+
+}  // namespace chromeos