Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936323004: [x64] Improve instruction selection for TruncateInt64ToInt32. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Improve instruction selection for TruncateInt64ToInt32. R=svenpanne@chromium.org Committed: https://crrev.com/64a2717529e2197f3a789adabf86ca36f5eb764c Cr-Commit-Position: refs/heads/master@{#26739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -40 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +17 lines, -5 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 2 chunks +38 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-19 09:36:46 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-19 09:40:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936323004/1
5 years, 10 months ago (2015-02-19 09:40:40 UTC) #5
Benedikt Meurer
Committed patchset #1 (id:1) manually as 64a2717529e2197f3a789adabf86ca36f5eb764c (presubmit successful).
5 years, 10 months ago (2015-02-19 09:42:01 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64a2717529e2197f3a789adabf86ca36f5eb764c Cr-Commit-Position: refs/heads/master@{#26739}
5 years, 10 months ago (2015-02-19 09:42:05 UTC) #8
Benedikt Meurer
5 years, 10 months ago (2015-02-23 07:08:25 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/928723003/ by bmeurer@chromium.org.

The reason for reverting is: Breaks SQLite.

Powered by Google App Engine
This is Rietveld 408576698