Chromium Code Reviews
Help | Chromium Project | Sign in
(695)

Issue 9363013: Fix integer issues in a way that caters for both 32-bit and 64-bit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by Chris Evans
Modified:
2 years, 1 month ago
Reviewers:
Will Drewry
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Pull in tweak from upstream. Hits sign extension in 64-bit.

BUG=116162

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Lint Patch
M third_party/libpng/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M third_party/libpng/pngrutil.c View 1 2 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 8
Chris Evans
As discussed!
2 years, 2 months ago #1
Will Drewry
LGTM The checking looks correct even though I hate relying on uint wrap (even if ...
2 years, 2 months ago #2
Tom Sepez
Rubberstamp LGTM.
2 years, 2 months ago #3
abarth
I attempt to LGTM it
2 years, 2 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9363013/2002
2 years, 2 months ago #5
I haz the power (commit-bot)
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
2 years, 2 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9363013/2002
2 years, 2 months ago #7
I haz the power (commit-bot)
2 years, 2 months ago #8
Change committed as 121019
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6