Chromium Code Reviews
Help | Chromium Project | Sign in
(127)

Issue 9363013: Fix integer issues in a way that caters for both 32-bit and 64-bit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Chris Evans
Modified:
3 years, 5 months ago
Reviewers:
Will Drewry
CC:
chromium-reviews
Visibility:
Public.

Description

Pull in tweak from upstream. Hits sign extension in 64-bit. BUG=116162

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/libpng/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libpng/pngrutil.c View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 8 (0 generated)
Chris Evans
As discussed!
3 years, 6 months ago (2012-02-08 03:41:51 UTC) #1
Will Drewry
LGTM The checking looks correct even though I hate relying on uint wrap (even if ...
3 years, 6 months ago (2012-02-08 03:54:51 UTC) #2
Tom Sepez (Out Aug 20-29)
Rubberstamp LGTM.
3 years, 6 months ago (2012-02-08 05:28:34 UTC) #3
abarth-chromium
I attempt to LGTM it
3 years, 6 months ago (2012-02-08 05:49:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9363013/2002
3 years, 6 months ago (2012-02-08 05:50:21 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
3 years, 6 months ago (2012-02-08 06:55:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9363013/2002
3 years, 6 months ago (2012-02-08 17:35:39 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2012-02-08 19:23:07 UTC) #8
Change committed as 121019
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld a4c4f45