chrome/android/java/res/layout/autofill_card_unmask_prompt.xml - Issue 936293002: Change expiration date spinners to text inputs, as per mocks.

Unified Diff: chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

Issue 936293002: Change expiration date spinners to text inputs, as per mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

diff --git a/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml b/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

index 5ce0169df2a1c51cfdcae37a0371585346d2d157..b51933d36d9385724114f1d4a0036dfb10ea5539 100644

--- a/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

+++ b/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

@@ -32,19 +32,38 @@

android:orientation="horizontal">

- <Spinner

- android:id="@+id/expiration_month"

- android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:layout_marginStart="16dp"

- android:visibility="gone" />

- <Spinner

- android:id="@+id/expiration_year"

+ <LinearLayout

+ android:id="@+id/expiration_container"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

- android:layout_marginStart="16dp"

- android:visibility="gone" />

+ android:orientation="horizontal"

+ android:visibility="gone">

+ <EditText

+ android:id="@+id/expiration_month"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:layout_marginStart="16dp"

+ android:ems="2"

+ android:gravity="center_horizontal"

newt (away) 2015/02/19 19:28:37 How does center_horizontal look when typing? Do th

Evan Stade 2015/02/19 20:02:48 Yes, they do, but it doesn't look bad to me.

+ android:inputType="number" />

+ <TextView

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:layout_marginStart="8dp"

+ android:layout_marginEnd="8dp"

+ android:text="/" />

newt (away) 2015/02/19 19:28:37 I think we might want to localize this string.

Evan Stade 2015/02/19 20:02:48 We might --- I'm not sure. But we don't do so in a

+ <EditText

+ android:id="@+id/expiration_year"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:ems="2"

+ android:gravity="center_horizontal"

+ android:inputType="number" />

+ </LinearLayout>

<EditText

android:id="@+id/card_unmask_input"