Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/android/java/res/layout/autofill_card_unmask_prompt.xml

Issue 936293002: Change expiration date spinners to text inputs, as per mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: work for year=2098 (I hope I live to see the day) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 3
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" 8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
9 android:layout_width="wrap_content" 9 android:layout_width="wrap_content"
10 android:layout_height="wrap_content"> 10 android:layout_height="wrap_content">
(...skipping 14 matching lines...) Expand all
25 android:layout_marginBottom="8dp" 25 android:layout_marginBottom="8dp"
26 android:layout_marginTop="10dp" 26 android:layout_marginTop="10dp"
27 android:gravity="start" /> 27 android:gravity="start" />
28 28
29 <LinearLayout 29 <LinearLayout
30 android:layout_width="match_parent" 30 android:layout_width="match_parent"
31 android:layout_height="wrap_content" 31 android:layout_height="wrap_content"
32 android:orientation="horizontal"> 32 android:orientation="horizontal">
33 33
34 <!-- TODO(estade): add accessibility content descriptions. --> 34 <!-- TODO(estade): add accessibility content descriptions. -->
35 <Spinner 35
36 android:id="@+id/expiration_month" 36 <LinearLayout
37 android:id="@+id/expiration_container"
37 android:layout_width="wrap_content" 38 android:layout_width="wrap_content"
38 android:layout_height="wrap_content" 39 android:layout_height="wrap_content"
39 android:layout_marginStart="16dp" 40 android:orientation="horizontal"
40 android:visibility="gone" /> 41 android:visibility="gone">
41 42
42 <Spinner 43 <EditText
43 android:id="@+id/expiration_year" 44 android:id="@+id/expiration_month"
44 android:layout_width="wrap_content" 45 android:layout_width="wrap_content"
45 android:layout_height="wrap_content" 46 android:layout_height="wrap_content"
46 android:layout_marginStart="16dp" 47 android:layout_marginStart="16dp"
47 android:visibility="gone" /> 48 android:ems="2"
49 android:gravity="center_horizontal"
50 android:inputType="number" />
51
52 <TextView
53 android:layout_width="wrap_content"
54 android:layout_height="wrap_content"
55 android:layout_marginStart="8dp"
56 android:layout_marginEnd="8dp"
57 android:text="/" />
58
59 <EditText
60 android:id="@+id/expiration_year"
61 android:layout_width="wrap_content"
62 android:layout_height="wrap_content"
63 android:ems="2"
64 android:gravity="center_horizontal"
65 android:inputType="number" />
66 </LinearLayout>
48 67
49 <EditText 68 <EditText
50 android:id="@+id/card_unmask_input" 69 android:id="@+id/card_unmask_input"
51 android:inputType="number" 70 android:inputType="number"
52 android:layout_height="wrap_content" 71 android:layout_height="wrap_content"
53 android:layout_width="wrap_content" 72 android:layout_width="wrap_content"
54 android:layout_marginStart="16dp" 73 android:layout_marginStart="16dp"
55 android:ems="4" 74 android:ems="4"
56 android:hint="@string/card_unmask_input_hint" /> 75 android:hint="@string/card_unmask_input_hint" />
57 76
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 android:visibility="gone" /> 132 android:visibility="gone" />
114 133
115 <TextView 134 <TextView
116 android:id="@+id/verification_message" 135 android:id="@+id/verification_message"
117 android:layout_width="wrap_content" 136 android:layout_width="wrap_content"
118 android:layout_height="wrap_content" 137 android:layout_height="wrap_content"
119 android:textColor="?android:attr/colorAccent" 138 android:textColor="?android:attr/colorAccent"
120 android:textSize="20dp" /> 139 android:textSize="20dp" />
121 </LinearLayout> 140 </LinearLayout>
122 </RelativeLayout> 141 </RelativeLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698