Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 936273002: Shorten "American Express" to "Amex" in Chrome UI. (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorten "American Express" to "Amex" in Chrome UI. "American Express" is still used for filling into the page. BUG=none Committed: https://crrev.com/d5c048a8f316b8bcd4971aec94e1ce19c20de3fe Cr-Commit-Position: refs/heads/master@{#317459}

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : update grit whitelist #

Patch Set 4 : gclient sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill_strings.grdp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Evan Stade
5 years, 10 months ago (2015-02-18 23:12:12 UTC) #2
Evan Stade
On 2015/02/18 23:12:12, Evan Stade wrote: ping (I'll fix unit test failures)
5 years, 10 months ago (2015-02-19 18:42:04 UTC) #3
brettw
lgtm
5 years, 10 months ago (2015-02-19 21:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936273002/40001
5 years, 10 months ago (2015-02-19 21:50:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/28371)
5 years, 10 months ago (2015-02-19 23:00:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936273002/40001
5 years, 10 months ago (2015-02-20 00:16:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/28469)
5 years, 10 months ago (2015-02-20 00:28:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936273002/60001
5 years, 10 months ago (2015-02-20 23:24:19 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-21 00:49:44 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:50:14 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d5c048a8f316b8bcd4971aec94e1ce19c20de3fe
Cr-Commit-Position: refs/heads/master@{#317459}

Powered by Google App Engine
This is Rietveld 408576698