Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js

Issue 936243004: Files.app: Start to use new metadata model in Audio Player. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
index 651c89162ace405c31d7f3eb7c2d5f58b3bc958e..7e163cab78347af00bccc15aa94f148d8214f2b3 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
@@ -77,7 +77,9 @@ ContentMetadataProvider.convertContentMetadata = function(metadata) {
var item = new MetadataItem();
item.contentThumbnailUrl = metadata['thumbnailURL'];
item.contentThumbnailTransform = metadata['thumbnailTransform'];
- item.contentImageTransform = metadata ['imageTransform'];
+ item.contentImageTransform = metadata['imageTransform'];
+ item.mediaTitle = metadata['title'];
+ item.mediaArtist = metadata['artist'];
return item;
};
@@ -190,10 +192,11 @@ ContentMetadataProvider.prototype.onResult_ = function(url, metadata) {
* @param {Object?} metadata The metadata, if available.
* @private
*/
-ContentMetadataProvider.prototype.onError_ =
- function(url, step, error, metadata) {
- if (MetadataCache.log) // Avoid log spam by default.
- console.warn('metadata: ' + url + ': ' + step + ': ' + error);
+ContentMetadataProvider.prototype.onError_ = function(
+ url, step, error, metadata) {
+ console.error(
+ 'ContentMetadataProvider failed to obtain metadata: '+
+ url + ': ' + step + ': ' + error);
this.onResult_(url, new MetadataItem());
};
@@ -203,6 +206,5 @@ ContentMetadataProvider.prototype.onError_ =
* @private
*/
ContentMetadataProvider.prototype.onLog_ = function(arglist) {
- if (MetadataCache.log) // Avoid log spam by default.
- console.log.apply(console, ['metadata:'].concat(arglist));
+ console.log.apply(console, ['ContentMetadataProvider log:'].concat(arglist));
};

Powered by Google App Engine
This is Rietveld 408576698