Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 936243004: Files.app: Start to use new metadata model in Audio Player. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Start to use new metadata model in Audio Player. BUG=410766 TEST=None Committed: https://crrev.com/395240b4e8e66980b4c1d2d173f29688c54c3ad0 Cr-Commit-Position: refs/heads/master@{#317019}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : Rebased. #

Patch Set 5 : Fixed. #

Patch Set 6 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -25 lines) Patch
M ui/file_manager/audio_player/audio_player.html View 1 2 3 4 1 chunk +14 lines, -3 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 7 chunks +11 lines, -11 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_scripts.js View 1 2 3 4 1 chunk +12 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 3 chunks +9 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-19 07:01:48 UTC) #2
yawano
Thank you! https://codereview.chromium.org/936243004/diff/40001/ui/file_manager/audio_player/js/audio_player_scripts.js File ui/file_manager/audio_player/js/audio_player_scripts.js (right): https://codereview.chromium.org/936243004/diff/40001/ui/file_manager/audio_player/js/audio_player_scripts.js#newcode27 ui/file_manager/audio_player/js/audio_player_scripts.js:27: <include src="../../file_manager/foreground/js/metadata/metadata_cache_set.js"> Please also add these files ...
5 years, 10 months ago (2015-02-19 07:51:05 UTC) #3
hirono
https://codereview.chromium.org/936243004/diff/40001/ui/file_manager/audio_player/js/audio_player_scripts.js File ui/file_manager/audio_player/js/audio_player_scripts.js (right): https://codereview.chromium.org/936243004/diff/40001/ui/file_manager/audio_player/js/audio_player_scripts.js#newcode27 ui/file_manager/audio_player/js/audio_player_scripts.js:27: <include src="../../file_manager/foreground/js/metadata/metadata_cache_set.js"> On 2015/02/19 07:51:05, yawano wrote: > Please ...
5 years, 10 months ago (2015-02-19 08:36:31 UTC) #4
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-19 08:38:10 UTC) #5
hirono
On 2015/02/19 08:38:10, yawano wrote: > lgtm. Thank you! Thanks!
5 years, 10 months ago (2015-02-19 08:59:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936243004/100001
5 years, 10 months ago (2015-02-19 08:59:33 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-19 09:21:44 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 09:22:12 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/395240b4e8e66980b4c1d2d173f29688c54c3ad0
Cr-Commit-Position: refs/heads/master@{#317019}

Powered by Google App Engine
This is Rietveld 408576698