Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 936243002: Bad QUIC proxies are now bypassed. (Closed)

Created:
5 years, 10 months ago by tbansal1
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bad QUIC proxies are now bypassed. This change ensures that if a QUIC proxy is unreachable, then it is marked as bad. Allows chrome to retry the request with the next proxy instead of showing ERR_QUIC_PROTOCOL to user. BUG=459426 Committed: https://crrev.com/53eef7f45df63b239e8ed04fce2f9e8f4cc11bfb Cr-Commit-Position: refs/heads/master@{#316964}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 2 chunks +7 lines, -0 lines 1 comment Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
tbansal1
5 years, 10 months ago (2015-02-18 22:53:09 UTC) #2
Ryan Hamilton
lgtm Nice catch!
5 years, 10 months ago (2015-02-19 00:02:33 UTC) #3
tbansal1
On 2015/02/19 00:02:33, Ryan Hamilton wrote: > lgtm > > Nice catch! Thank you for ...
5 years, 10 months ago (2015-02-19 00:10:00 UTC) #4
tbansal1
5 years, 10 months ago (2015-02-19 00:10:10 UTC) #5
tbansal1
5 years, 10 months ago (2015-02-19 00:10:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936243002/1
5 years, 10 months ago (2015-02-19 00:11:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 01:47:57 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53eef7f45df63b239e8ed04fce2f9e8f4cc11bfb Cr-Commit-Position: refs/heads/master@{#316964}
5 years, 10 months ago (2015-02-19 01:48:52 UTC) #10
Ryan Hamilton
https://codereview.chromium.org/936243002/diff/1/net/http/http_stream_factory_impl_job.cc File net/http/http_stream_factory_impl_job.cc (right): https://codereview.chromium.org/936243002/diff/1/net/http/http_stream_factory_impl_job.cc#newcode907 net/http/http_stream_factory_impl_job.cc:907: result == ERR_QUIC_PROTOCOL_ERROR) { I think you might also ...
5 years, 10 months ago (2015-02-19 17:02:25 UTC) #11
tbansal1
On 2015/02/19 17:02:25, Ryan Hamilton wrote: > https://codereview.chromium.org/936243002/diff/1/net/http/http_stream_factory_impl_job.cc > File net/http/http_stream_factory_impl_job.cc (right): > > https://codereview.chromium.org/936243002/diff/1/net/http/http_stream_factory_impl_job.cc#newcode907 ...
5 years, 10 months ago (2015-02-19 18:03:28 UTC) #12
tbansal1
5 years, 10 months ago (2015-02-19 18:03:33 UTC) #13
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698