Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936203002: Disable notifications extension in component loader if launcher field trial is running (ChromeOS on… (Closed)

Created:
5 years, 10 months ago by skare_
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, rgustafson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable now notifications extension in component loader if launcher field trial is running (ChromeOS only) BUG=460164 Committed: https://crrev.com/e67ebcf0c6ffb60279ffee8ba4722d904857b67e Cr-Commit-Position: refs/heads/master@{#317095}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/extensions/component_loader.cc View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
skare_
5 years, 10 months ago (2015-02-19 06:03:31 UTC) #2
robliao
lgtm https://codereview.chromium.org/936203002/diff/20001/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/936203002/diff/20001/chrome/browser/extensions/component_loader.cc#newcode623 chrome/browser/extensions/component_loader.cc:623: std::string google_now_extension_id; OPTIONAL: Could rename to ignored_extension_id.
5 years, 10 months ago (2015-02-19 06:06:53 UTC) #3
skare_
https://codereview.chromium.org/936203002/diff/20001/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/936203002/diff/20001/chrome/browser/extensions/component_loader.cc#newcode623 chrome/browser/extensions/component_loader.cc:623: std::string google_now_extension_id; On 2015/02/19 06:06:53, robliao wrote: > OPTIONAL: ...
5 years, 10 months ago (2015-02-19 15:20:28 UTC) #5
skare_
+kalman@ for extensions/component_loader.cc OWNERS
5 years, 10 months ago (2015-02-19 17:32:23 UTC) #8
not at google - send to devlin
is there a bug? anyway, lgtm.
5 years, 10 months ago (2015-02-19 17:45:34 UTC) #9
robliao
Still lgtm.
5 years, 10 months ago (2015-02-19 18:16:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936203002/80001
5 years, 10 months ago (2015-02-19 19:17:48 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-19 19:21:40 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:22:30 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e67ebcf0c6ffb60279ffee8ba4722d904857b67e
Cr-Commit-Position: refs/heads/master@{#317095}

Powered by Google App Engine
This is Rietveld 408576698