add gn_all, gyp_all targets to build files, remove GN's //:root

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 6ca1cda7b544228f933bb9e8a6a2b4b149d0fd0a..357497e6f1ccd3deb6451d1447ca4bbe5f3a4f01 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -8,7 +8,9 @@
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
+import("//build/config/features.gni")

[brettw, 2015/02/23 18:36:21]

Sadness... oh well. We can optimize this later if necessary (this basically
blocks the entire GN run on synchronously loading this file).

[Dirk Pranke, 2015/02/23 19:17:43]

Yeah ...

 import("//build/config/ui.gni")
+
 if (is_android) {
   import("//build/config/android/config.gni")
 }
@@ -302,3 +304,269 @@ group("root") {
     deps -= [ "//ui/touch_selection" ]
   }
 }
+
+group("gyp_all") {

[brettw, 2015/02/23 18:36:21]

I don't have a strong objection to this, but it seems weird to me. Why not just
put these targets in the list below with the TODO(GYP) comment? It seems like
this target will only ever have one uncommented dependency on gn_all.

[Dirk Pranke, 2015/02/23 19:17:43]

Yes. Mostly it exists for symmetry w/ gyp_all, but this is arguably pointless,
as you say.

Mostly I hope to kill off gyp_all in both GN and GYP builds pretty quickly.

+  testonly = true
+
+  # TODO(GYP): This target should describe everything that is built by a GYP
+  # build but not yet by a GN build, i.e., these are the targets that still
+  # need to be ported to GN. Eventually this target should be identical to
+  # gn_all.
+
+  deps = [
+    ":gn_all",
+    # "//chrome/test:chromedriver_unittests", # TODO(GYP)
+    # "//components:components_browsertests", # TODO(GYP)
+    # "//components/nacl:nacl_loader_unittests", # TODO(GYP)
+    # "//google_apis:google_apis_unittests", # TODO(GYP)
+    # "//ui/compositor:compositor_unittests", # TODO(GYP)
+    # "//device:device_unittests", # TODO(GYP)
+    # "//ppapi:ppapi_unittests", # TODO(GYP)
+    # "//remoting:remoting_unittests",  # TODO(GYP)
+  ]
+}
+
+# The "gn_all" target matches the "gn_all" target in build/all.gyp.
+# It is not (yet!) the same as building "all".
+# TODO(GYP): Make it be basically the same as building all, or at least
+# be sure that we don't want any of the stuff listed in gn_all to
+# be built by default.
+
+# In GN, a "group" is a dummy target that just lists other targets.
+group("gn_all") {
+  testonly = true
+
+  deps = [
+    "//base:base_unittests",
+    "//cc:cc_unittests",
+    "//chrome",
+    "//chrome/test:browser_tests",
+    "//chrome/test:interactive_ui_tests",
+    "//chrome/test:sync_integration_tests",
+    "//chrome/test:unit_tests",
+    "//components:components_unittests",
+    "//content/shell:content_shell",
+    "//content/test:content_browsertests",
+    "//content/test:content_perftests",
+    "//content/test:content_unittests",
+    "//crypto:crypto_unittests",
+    "//extensions:extensions_browsertests",
+    "//extensions:extensions_unittests",
+    "//google_apis/gcm:gcm_unit_tests",
+    "//gpu:gpu_unittests",
+    "//ipc:ipc_tests",
+    "//ipc/mojo:ipc_mojo_unittests",
+    "//jingle:jingle_unittests",
+    "//media:media_unittests",
+    "//media/mojo",
+    "//media/cast:cast_unittests",
+    "//mojo",
+    "//mojo/common:mojo_common_unittests",
+    "//mojo/services/html_viewer:tests",
+    "//net:net_unittests",
+    "//ppapi/examples",
+    "//printing:printing_unittests",
+    "//sql:sql_unittests",
+    "//sync:sync_unit_tests",
+
+    # TODO(GYP): the Blink test targets should be public, but
+    # currently aren't. all_blink pulls them in, though.
+    # "//third_party/WebKit/Source/platform:heap_unittests",
+    # "//third_party/WebKit/Source/platform:platform_unittests",
+    # "//third_party/WebKit/Source/wtf:wtf_unittests",
+    "//third_party/WebKit/public:all_blink",
+    "//third_party/cacheinvalidation:cacheinvalidation_unittests",
+
+    # TODO(GYP): This is needed only w/ cld_version==1. What configs set that?
+    "//third_party/cld",
+
+    # TODO(GYP): This is needed only w/ use_system_fontconfig==0.
+    # What configs set that?
+    "//third_party/fontconfig",
+
+    # TODO(GYP): This will be pulled in automatically when enable_webrtc==true.
+    # For now pull it in manually so that it doesn't regress.
+    "//third_party/libsrtp",
+    "//third_party/mojo/src/mojo/edk/system:mojo_system_unittests",
+    "//third_party/mojo/src/mojo/edk/test:mojo_public_bindings_unittests",
+    "//third_party/mojo/src/mojo/edk/test:mojo_public_environment_unittests",
+    "//third_party/mojo/src/mojo/edk/test:mojo_public_system_unittests",
+    "//third_party/mojo/src/mojo/edk/test:mojo_public_utility_unittests",
+    "//third_party/pdfium/samples:pdfium_test",
+
+    # TODO(GYP): Verify that this is no longer needed.
+    "//third_party/smhasher:pmurhash",
+
+    # TODO(GYP): This will be pulled in automatically when enable_webrtc==true.
+    # For now pull it in manually so that it doesn't regress.
+    "//third_party/usrsctp",
+    "//tools/imagediff",
+    "//tools/gn",
+    "//tools/gn:gn_unittests",
+    "//ui/accessibility:accessibility_unittests",
+    "//ui/app_list:app_list_unittests",
+    "//ui/base:ui_base_unittests",
+    "//ui/display:display_unittests",
+    "//ui/events:events_unittests",
+    "//ui/gfx:gfx_unittests",
+    "//ui/touch_selection:ui_touch_selection_unittests",
+    "//ui/views:views_unittests",
+    "//url:url_unittests",
+    "//skia:skia_unittests",
+  ]
+
+  deps += root_extra_deps
+
+  if (!is_win) {
+    deps += [ "//breakpad:symupload" ]
+  }
+
+  if (use_x11) {
+    deps += [ "//tools/xdisplaycheck" ]
+  }
+
+  if (use_aura) {
+    deps += [ "//ui/wm:wm_unittests" ]
+  }
+
+  if (use_ozone) {
+    deps += [
+      "//ui/ozone",  # TODO(GYP) Needed??
+      "//ui/ozone/demo",  # TODO(GYP) Needed??
+    ]
+  }
+
+  if (is_win || is_mac || is_chromeos) {
+    # RLZ works on these platforms.
+    # TODO(GYP): Is this target needed, or pulled in automatically?
+    deps += [ "//rlz:rlz_lib" ]
+  }
+
+  if (is_android) {
+    deps += [
+      "//base/android/linker:chromium_android_linker",
+      "//build/android/gyp/test:hello_world",
+      "//build/android/rezip",
+      "//chrome/android:chrome_shell_apk",
+      "//chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_apk",
+      "//tools/imagediff($host_toolchain)",
+
+      # TODO(GYP): Remove these when the components_unittests work.
+      "//components/history/core/test:test",
+      "//components/policy:policy_component_test_support",
+      "//components/policy:test_support",
+      "//components/rappor:test_support",
+      "//components/signin/core/browser:test_support",
+      "//components/sync_driver:test_support",
+      "//components/user_manager",
+      "//components/wallpaper",
+      "//content/shell/android:content_shell_apk",
+
+      # TODO(GYP): Are these needed, or will they be pulled in automatically?
+      "//third_party/android_tools:android_gcm_java",
+      "//third_party/android_tools:uiautomator_java",
+      "//third_party/android_tools:android_support_v13_java",
+      "//third_party/android_tools:android_support_v7_appcompat_java",
+      "//third_party/android_tools:android_support_v7_mediarouter_java",
+      "//third_party/mesa",
+      "//third_party/mockito:mockito_java",
+      "//third_party/openmax_dl/dl",
+      "//third_party/speex",
+      "//ui/android:ui_java",
+
+      # TODO(GYP): Are these needed?
+      "//chrome/test:test_support_unit",
+      "//third_party/smhasher:murmurhash3",
+      "//ui/message_center:test_support",
+    ]
+    deps -= [
+      "//breakpad:symupload",  # TODO(GYP) ??
+      "//chrome",  # TODO(GYP) ??
+      "//chrome/test:browser_tests",  # TODO(GYP) ??
+      "//chrome/test:interactive_ui_tests",  # TODO(GYP) ??
+      "//chrome/test:sync_integration_tests",  # TODO(GYP) ??
+      "//chrome/test:unit_tests",  # TODO(GYP)
+      "//extensions:extensions_browsertests",
+      "//extensions:extensions_unittests",
+      "//google_apis/gcm:gcm_unit_tests",
+      "//ipc:ipc_tests",  # TODO(GYP) ??
+      "//jingle:jingle_unittests",  # TODO(GYP) ??
+      "//net:net_unittests",
+      "//ppapi/examples",
+      "//third_party/fontconfig",  # TODO(GYP) ??
+      "//third_party/pdfium/samples:pdfium_test",
+      "//tools/gn",
+      "//tools/gn:gn_unittests",
+      "//ui/app_list:app_list_unittests",
+      "//ui/views:views_unittests",
+      "//url:url_unittests",
+    ]
+
+    if (has_chrome_android_internal) {
+      deps += [ "//clank" ]  # TODO(GYP) ??
+    }
+  } else if (is_linux) {
+    deps += [
+      "//dbus:dbus_unittests",
+      "//sandbox/linux:sandbox_linux_unittests",
+    ]
+  } else if (is_mac) {
+    deps += [
+      # TODO(GYP): Remove these when the targets below work and these
+      # are pulled in automatically.
+      "//cc/blink",
+      "//components/ui/zoom:ui_zoom",
+      "//content",
+      "//content/test:test_support",
+      "//device/battery",
+      "//device/bluetooth",
+      "//device/nfc",
+      "//device/usb",
+      "//device/vibration",
+      "//media/blink",
+      "//pdf",
+      "//storage/browser",
+      "//third_party/brotli",
+      "//third_party/flac",
+      "//third_party/hunspell",
+      "//third_party/iccjpeg",
+      "//third_party/libphonenumber",
+      "//third_party/ots",
+      "//third_party/qcms",
+      "//third_party/smhasher:murmurhash3",
+      "//third_party/speex",
+      "//third_party/webrtc/system_wrappers",
+      "//ui/native_theme",
+      "//ui/snapshot",
+      "//ui/surface",
+    ]
+
+    deps -= [
+      "//chrome",  # TODO(GYP)
+      "//chrome/test:browser_tests",  # TODO(GYP)
+      "//chrome/test:interactive_ui_tests",  # TODO(GYP)
+      "//chrome/test:sync_integration_tests",  # TODO(GYP)
+      "//chrome/test:unit_tests",  # TODO(GYP)
+      "//components:components_unittests",  # TODO(GYP)
+      "//content/test:content_browsertests",  # TODO(GYP)
+      "//content/test:content_perftests",  # TODO(GYP)
+      "//content/test:content_unittests",  # TODO(GYP)
+      "//extensions:extensions_browsertests",  # TODO(GYP)
+      "//extensions:extensions_unittests",  # TODO(GYP)
+      "//mojo/services/html_viewer:tests",  # TODO(GYP)
+      "//net:net_unittests",  # TODO(GYP)
+      "//third_party/fontconfig",  # TODO(GYP) ??
+      "//third_party/usrsctp",  # TODO(GYP)
+      "//ui/app_list:app_list_unittests",  # TODO(GYP)
+      "//ui/gfx:gfx_unittests",  # TODO(GYP)
+      "//ui/views:views_unittests",  # TODO(GYP)
+    ]
+  } else if (is_win) {
+    deps += [ "//ui/metro_viewer" ]
+    deps -= [
+      "//crypto:crypto_unittests",  # TODO(GYP)
+      "//net:net_unittests",  # TODO(GYP)
+      "//third_party/fontconfig",  # TODO(GYP) ??
+    ]
+  }
+}